Comments (17)
Haven't had a chance to look at this... Thanks for the research!
Sounds like maybe all we need to do is wrap the success
plugin like we do the others. The primary reason this library even exists is to allow monkey patching the output of getCommits
to filter commits based on package since semantic-release
won't allow it.
from semantic-release-monorepo.
Our releases are taking longer and longer because it's adding so many comments to PRs. If someone can point me to the location of what to fix, I can take a stab at it. Maybe wrapping the success plugin?
from semantic-release-monorepo.
Thanks so much for trying it out @travi! That's good enough for me... just published a new release with the fix!
from semantic-release-monorepo.
I think you're right! Haven't had a chance to look into it. Here's a few related issues:
semantic-release/github#50
semantic-release/github#63
Help wanted!
from semantic-release-monorepo.
As a temporary workaround, the comments can be turned off by overriding the default success
and fail
plugins (e.g. set them to empty arrays) in the release configuration
from semantic-release-monorepo.
I did some investigation and see that github/success
function receives context.commits
and that array of commits are not filtered by semanatic-release-monorepo
.
Will try to understand why is that
from semantic-release-monorepo.
semantic-release
looking for all commits starting until last release:
const commits = await getCommits(lastRelease.gitHead, options.branch, logger);
Later it passes this array of commits to every plugin call, in options.commits
. That's why github plugin receives the list of all commits, parses them and send comments to wrong issues.
from semantic-release-monorepo.
Has there been an update on this? It's pretty noise right now every time a release happens.
from semantic-release-monorepo.
@milesj I don't have an update for you at the moment. But we will be looking into this in the next week or so.
from semantic-release-monorepo.
Is there a way to help you?
from semantic-release-monorepo.
I have a branch up that should fix this, github-comments-fix
, if anyone's willing to give it a try.
from semantic-release-monorepo.
Has anyone tried this? Can we get this fixed in the package?
from semantic-release-monorepo.
Just FYI:
I switched to solution semantic-release/semantic-release#193 (comment)
Similar hack but is much simpler and augments only single package. Havenβt tried to enable release comments however. Better cross-release support
from semantic-release-monorepo.
Just FYI:
I switched to solution semantic-release/semantic-release#193 (comment)
Similar hack but is much simpler and augments only single package. Havenβt tried to enable release comments however. Better cross-release support
You should check out semantic-release-plus! Should be essentially the same, but itβs always kept up to date with semantic-release itself.
from semantic-release-monorepo.
I have a branch up that should fix this, github-comments-fix, if anyone's willing to give it a try.
@pmowrer i've been testing this branch out a fair amount today, and it seems to be working as i would expect. what would it take to include this in a published release (even a pre-release would be ok with me)?
from semantic-release-monorepo.
π This issue has been resolved in version 7.0.3 π
The release is available on:
Your semantic-release bot π¦π
from semantic-release-monorepo.
thanks!
from semantic-release-monorepo.
Related Issues (20)
- [bug] semantic-release-monorepo ignores pkgRoot HOT 10
- get the releasing workspace HOT 1
- Non-javascript project generates new version for every package HOT 2
- semantic-release-monorepo is updateing the version of both apps when only one app was updated. HOT 2
- Node 16/18 support HOT 1
- [Question] different .releaserc files HOT 1
- [Bug]: analyzeCommits doesn't run monorepo login on newer commit HOT 4
- chore: remove $ from command HOT 1
- Problem with resolving `pnpm`'s `workspace:*` references HOT 3
- Commit analyzation doesn't pick up any commits to release HOT 3
- node 18 support HOT 4
- ERR_REQUIRED_ESM error with semantic-release/gitlab HOT 11
- ERR_REQUIRED_ESM error with multiple plugin packages HOT 8
- Failure when multiple packages are published in one commit due to Git conflict HOT 1
- Github doesn't correctly identify and push the tags for release to my repository HOT 1
- Configure for multiple package roots? HOT 7
- ESM Version does not work HOT 4
- Error: __dirname is not defined HOT 1
- --no-git-tag-version --allow-same-version' after upgrading to version 8.0.2
- Branch name becomes undefined once a release happen in a previous package HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from semantic-release-monorepo.