Enable/Disable all relevant items or none about compareplus

[pnedev]

Hi Yaron,

Those are actually useful. They make compare results jump controls inactive when you haven't compared anything. Why would you need "Go to next compare result" command when you haven't actually run compare?

BR,
Pavel

[Yaron10]

Hello Pavel,

It's not realty important. Just a matter of consistency.
Why is "Clear Results" always active? And you can go even further: Why is "Compare" active if only one file is open? And "Compare to last Save"?

I have "Compare", "First" (etc.) and "Clear Results" in my toolbar; so it's a bit more prominent.
I don't think we should enable/disable ALL commands and I don't know if the navigation buttons should be different.
What do you think?

Thank you.

Best regards.

[pnedev]

Hello Yaron,

Hm, you are right about "Compare", "Clear Results", etc., good point.

The reason I'm having second thoughts about the results navigation commands is because I was planning to disable "First" and "Prev" in case you are at the top of the changes or disable "Last", "Next" if you are at the last (or beyond) change respectively. I think it might be a good indication to the user but I would like to see first how complicated this would be to implement and decide if it is justified.

What do you think?

BR

[Yaron10]

Hello Pavel,

That's a clever idea. I was impressed.
Thank you.

"First" and "Last":
Shouldn't these commands be enabled even if you're further up or down in the file?

"Prev" and "Next":
Implementing your suggestion would mean disabling "Wrap Around".
In NPP Search this feature is optional; Don't you think some Compare users may find it convenient?

I use a Python Script "Select and Find First".
If the current selection is the first occurrence, the indication to the user is flashing the selection for a couple of seconds.
How about flashing the first and last diffs?
I remember you don't like sound notifications. :)

Select and Find First.zip

Best regards.

[pnedev]

Hello Yaron,

"First" and "Last":
Shouldn't these commands be enabled even if you're further up or down in the file?

Yes, perhaps, good point.

Implementing your suggestion would mean disabling "Wrap Around".
In NPP Search this feature is optional; Don't you think some Compare users may find it convenient?

Yes, "Wrap Around" will be gone.
About the users... Well it is impossible to make everyone happy :)
I'd rather implement the things the way I like them and then get feedback from the users and correct than to wait forever until everyone agrees on a single solution.
I think it is not that hard from user perspective to use "First" if "wrap-around" is what you need. But that makes it explicit which IMHO is something good in that case.

My idea comes from all the stand-alone compare programs I've used so far - they all disable "Prev" and "Next" controls when you reach the first / last diff.

What do you think?

BR

[xylographe]

If it is possible to enquire the wrap-around setting from NPP find, you could use the same wrap-around behaviour in CP?

[pnedev]

Hello xylographe,

Thank you for the suggestion.
However I prefer to implement new Compare plugin option for Wrap mode if need be than to reuse the NPP one. That would add more flexibility.

BR

[Yaron10]

Hello Pavel,

I think your suggestion is a good and useful enhancement. 👍
If making it optional wouldn't require a lot of extra work, it would be even better. :)
Thank you very much.

Best regards.

[Yaron10]

Hello xylographe,

Thank you for your contribution.

I was once trying to get other settings from the Find dialog for a Python Script, and Dave (PS dev) wrote to me that it was impossible.

Best regards.

[pnedev]

Hello Yaron,

I'm about to close this issue.
I'll postpone for now the implementation of the feature we discussed until more urgent tasks are completed.
Shall I disable all other commands for consistency? I mean this:

Why is "Clear Results" always active? And you can go even further: Why is "Compare" active if only one file is open? And "Compare to last Save"?

BR

[Yaron10]

Hello Pavel,

I'll postpone for now the implementation of the feature we discussed until more urgent tasks are completed.

You're the boss. :) I agree with your triage.

Shall I disable all other commands for consistency?

I think that's a good idea (so long as you haven't implemented your suggestion).
Thank you.

BR.

[pnedev]

Hello Yaron,

OK then, I'll check the other commands enable/disable later.
Keeping this open for now.

BR

[Yaron10]

Hello Pavel,

Shall I disable all other commands for consistency?

I didn't read your question carefully. Sorry.
I thought you meant enabling First etc. for consistency (my original suggestion).
IMO, enabling/disabling all commands is not that important and I wonder if it's worth the work involved.
It doesn't give the user any useful indication (unlike the Save command for example).

Thank you.

[pnedev]

Hello Yaron,

All right then. I'll close this issue now and sometime later will think of implementing the idea with disabling Next / Prev when you reach the last / first diff.
Thanks.

BR

[Yaron10]

Thank you very much.
BR.