Add setup-node code to examples about action-setup

[KSXGitHub]

So to be on the safer side, so that your actions won't error out, can we always use setup node (though pnpm doesn't need it) as a best practice.

Yes. This action does not care about whatever version setup-node installs. And whatever version this action uses does not affect your code.

[KSXGitHub]

@melMass I will accept a PR that adds a code example that use pnpm/action-setup and actions/setup-node with cache key. There is already a section called "Use cache to reduce installation time" in README.md, you may rename it to "With actions/cache" (or something) and add another section named "Use the cache key in actions/setup-node".

[KSXGitHub]

This action by itself does not require setup-node, and isn't affected by setup-node, so you'll need to add that clarification in the example. I'll be waiting for your PR.

[rajasegar]

This action by itself does not require setup-node, and isn't affected by setup-node, so you'll need to add that clarification in the example. I'll be waiting for your PR.

What do you mean by itself does not require setup-node? Are you implying without setup-node this action alone will work? How can we set something like what version of Node.js to use with this action without setup-node?

[KSXGitHub]

Are you implying without setup-node this action alone will work?

Yes. But only for installing pnpm. User still have to use setup-node to run their own JavaScript code.

How can we set something like what version of Node.js to use with this action without setup-node?

The action will not let user specify what Node.js version the action use because it is an implementation detail. Besides, the Node.js version that pnpm uses is irrelevant to the dependencies it installs, why do you care about it anyway?

[rajasegar]

I often end up changing my node version for specific jobs in the workflows like semantic-release, that's why I specifically need to set the node version.
So to be on the safer side, so that your actions won't error out, can we always use setup node (though pnpm doesn't need it) as a best practice.

[melMass]

I agree that a full on example would be great 🙏
Trying to use it right now and they suggest setting the cache key to the package manager used pnpm in my case but I have the following error:

Edit: Well for my case it happened to be simpler than I thought pnpm must be installed BEFORE Node.js

More info here: https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-dependencies