GithubHelp home page GithubHelp logo

Comments (9)

rstacruz avatar rstacruz commented on May 18, 2024

That'd be interesting. We're currently using got, but not by much, so it might be easy to switch to http2 with possible http fallback.

If there's a package that already handles this, lemme know (I don't know of any!). PR's are also welcome.

from pnpm.

gunta avatar gunta commented on May 18, 2024

Unfortunately there is no package that wraps this.

I've created an Issue for GOT here:
sindresorhus/got#167

Otherwise, we would have to use is-http2 along with node-http2.
https://github.com/stefanjudis/is-http2

Or create a new package.

from pnpm.

gunta avatar gunta commented on May 18, 2024

Ok seems that its gonna be easier to fix on the GOT side.

However we might add here the spdy module as a dependency in pnpm to have HTTP2 support enabled by default.

from pnpm.

zkochan avatar zkochan commented on May 18, 2024

@gunta we now use the same package that npm uses to make http requests (https://github.com/npm/npm-registry-client). Do you think this issue is still relevant?

from pnpm.

gunta avatar gunta commented on May 18, 2024

@zkochan Still relevant. They use request which doesn't support http2 neither.

Since it doesn't looks too difficult, we could hack something like this in the meantime: http://stackoverflow.com/questions/37653110/is-there-a-request-like-package-using-http2

from pnpm.

zkochan avatar zkochan commented on May 18, 2024

I see. We can try to make a pull request to npm-registry-client. If they won't accept it, we can fork it and use the fork.

from pnpm.

DanielRuf avatar DanielRuf commented on May 18, 2024

Is this still relevant? Node 10 (and probably earlier releases) supports http2 internally (at least "experimental").

https://nodejs.org/api/http2.html#http2_http_2

from pnpm.

aparajita avatar aparajita commented on May 18, 2024

@zkochan Do you still want to consider this? Since node-fetch doesn't seem to support http2, it would mean switching to something like fetch-h2.

from pnpm.

zkochan avatar zkochan commented on May 18, 2024

sure, would be nice to see if we get a performance boost with that library.

from pnpm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.