GithubHelp home page GithubHelp logo

Port to Firefox about podstation HOT 4 OPEN

podstation avatar podstation commented on June 3, 2024
Port to Firefox

from podstation.

Comments (4)

dellagustin avatar dellagustin commented on June 3, 2024

Initial tests

Initial tests after removing issues on the locale pt-br file produced the following warnings and errors

Warnings

When installing the extension from the manifest file, firefox produced the following Warnings:

  • Reading manifest: Warning processing background.persistent: Event pages are not currently supported. This will run as a persistent background page.

  • Reading manifest: Warning processing commands.play_pause.global: An unexpected property was found in the WebExtension manifest.

  • Reading manifest: Warning processing options_page: An unexpected property was found in the WebExtension manifest.

Errors

Inspecting the consoe showed the following errors :

  • Content Security Policy: The page’s settings blocked the loading of a resource at eval (“script-src”). angular.js:1086:6

  • storageObject is undefined

  • Unchecked lastError value: Error: The storage API will not work with a temporary addon ID. Please add an explicit addon ID to your manifest. For more information see https://bugzil.la/1323228.

  • browser.app is undefined

from podstation.

dellagustin avatar dellagustin commented on June 3, 2024

After 8822976 I have packaged the extension on chrome generating a crx file and uploaded it to https://www.extensiontest.com/ and run its test.

The result is attached here
report.zip

Many warnings should be resolved by setting a newer strict_min_version.

Deep dive

Content security policy

{
      "message": "\"content_security_policy\" allows remote code execution in manifest.json",
      "description": "A custom content_security_policy needs additional review.",
      "locations": [ ... ]
    },

This will require a decision, we either:

  1. keep the csp as is to allow for google analytics,
  2. try to embed the google analytics code in the extension,
  3. remove google analytics for FF or
  4. remove google analytics for all browsers
  • Decide what to do with csp and google analytics.

Manifest key "author"

Error:

{
      "message": "Manifest key not supported by the specified minimum Firefox version",
      "description": "\"strict_min_version\" requires Firefox 42.0, which was released before version 52 introduced support for \"author\".",
      "locations": [ ... ]
    },
    {
      "message": "Manifest key not supported by the specified minimum Firefox for Android version",
      "description": "\"strict_min_version\" requires Firefox for Android 42.0, which was released before version 52 introduced support for \"author\".",
      "locations": [ ... ]
    },

This could be solved by setting "strict_min_version" to 52, but I don't this is necessary, as I don't imagine that the add-on will not work because of this additional key, requires testing though.

  • Test loading the extension in FF < 52 with the "author" manifest key.

from podstation.

paulaime avatar paulaime commented on June 3, 2024

Hi,
Any update on this? I was using it on Chromium, but I mainly use Firefox, so it'd be great to be able to use it since it's an awesome podcast player. Thank you for your great work!

from podstation.

dellagustin avatar dellagustin commented on June 3, 2024

Hello @paulaime , thanks for asking.
I have not worked on this topic for a long time. To be honest, I don't think I will work on this on the near future, I have a major feature to work on, that is the migration form Manifest v2 to v3. Google announced that v2 will be phased out on end of January 31st (https://github.com/podStation/podStation/milestone/5), this will require a full refactoring of many parts of the software.

from podstation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.