GithubHelp home page GithubHelp logo

Comments (5)

frading avatar frading commented on May 21, 2024 1

hey @kungfooman thanks a lot for the heads up, really appreciate. Will fix those shortly.

from polygonjs.

frading avatar frading commented on May 21, 2024 1

@kungfooman I've just updated the readme. I should absolutely have kept those up to date, so thanks a lot again for letting me know.

That said, I plan to remove those 2 examples, as they're not representative on how I recommend to use polygonjs. Using it with the visual editor (either on https://polygonjs.com, or via the npm module npx polygonjs-editor) has many more benefits, the main one being that it will auto generate the imports for you, keeping the bundle size to a minimum.

But those examples are still good to get a sense of the api needed to go beyond what the editor can do. So I'll probably move them in the docs, under the api section.

Don't hesitate if you spot anything else, I'll do my best to help.

from polygonjs.

frading avatar frading commented on May 21, 2024 1

oh I see. Yes, you're right.
At the moment, there is no warning since it's possible to create the viewer without mounting it, but that doesn't seem quite right if the element option is given. I'll have a think, I may indeed just add the html you mention.

from polygonjs.

kungfooman avatar kungfooman commented on May 21, 2024

2nd example is also broken:

image

If you want people to test it out, make at least the examples work 😅

from polygonjs.

kungfooman avatar kungfooman commented on May 21, 2024

Thank you for fixing, its still missing a <div id="app"></div> and if you forget about it, the engine doesn't warn about anything, which it probably should.

from polygonjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.