GithubHelp home page GithubHelp logo

Comments (7)

majk-p avatar majk-p commented on August 18, 2024 1

I've looked into it, and it seems using generic solution described above might be an overkill. We might revisit this idea later, but I've prepared a PR fixing this specific issue in #114

from sttp-oauth2.

majk-p avatar majk-p commented on August 18, 2024 1

@vakhtang fix is now merged and released with v.0.11.0

from sttp-oauth2.

kubukoz avatar kubukoz commented on August 18, 2024

Thanks for reporting!

Had a quick look, this seems to check out but I'll defer to the local expert @majk-p 😅

from sttp-oauth2.

vakhtang avatar vakhtang commented on August 18, 2024

Thanks for the prompt response @kubukoz. I'm happy to open a PR for the change if we're all in agreement.

from sttp-oauth2.

majk-p avatar majk-p commented on August 18, 2024

Hi @vakhtang, thanks for the report! You are right that we don't follow the OAuth spec here, and we should fix that.
We were thinking about solution similar to this one: #104 introduced for AuthorizationCodeGrant. The bottom line would be to allow end user to specify the response type, while we'd provide a basic one (similar to OAuth2TokenResponse.Basic).
If you are willing to implement it that way, we are happy to accept a contribution 👍

from sttp-oauth2.

kubukoz avatar kubukoz commented on August 18, 2024

@majk-p the default one should still be spec compliant, so we should probably make the field optional (and eventually remove it) anyway 😅

from sttp-oauth2.

majk-p avatar majk-p commented on August 18, 2024

On one hand it makes sense to go step by step, making the field optional. On the other hand both of those are breaking the API and we'd like to have as few of them as possible.

from sttp-oauth2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.