It's killing me! about hitchcock

[pomber]

"There is no terror in the bang, only in the anticipation of it." 😛
I'll try to push it this weekend

[tsiq-swyx]

ok :) was hoping to include you in a Suspense presentation im giving on wednesday

…

On Tue, Mar 27, 2018 at 9:27 AM, Rodrigo Pombo ***@***.***> wrote: "There is no terror in the bang, only in the anticipation of it." 😛 I'll try to push it this weekend — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AiT1gkeaCZYsjvqA_BUGVnNv51i7iwg-ks5tij5cgaJpZM4S76PT> .

[pomber]

Still very experimental but here is a demo: https://codesandbox.io/s/kk2v1op3m5

[tsiq-swyx]

THIS IS AMAZING. WOW!!!

…

On Mon, Apr 2, 2018 at 9:17 PM, Rodrigo Pombo ***@***.***> wrote: Still very experimental but here is a demo: https://codesandbox.io/s/ kk2v1op3m5 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AiT1gg_gfrmT2HxyKPTZS1joyB0-ut64ks5tks2agaJpZM4S76PT> .

[tsiq-swyx]

any idea what happens when promises get rejected? they seem to be saying on twitter that componentDidCatch should be able to catch the rejected promise, but my experiments don't seem to be bearing this out.

[pomber]

Are you talking about hitchcock or react suspense in general?

For hitchcock it's not implemented yet.

For the rest of the cases, I think it depends on the cache you are using if you are using any. Apparently, the cache should handle the promise rejection, store the error and throw it the next time you try to read that key.

Here is how simple-cache-provider does it.

[tsiq-swyx]

i think this applies to both.

so just to be clear we're on the same page, i add a throw (or a reject) in your API:

and then i wrap with an Error Boundary:

I understand that you havent implemented the reject caching in your cache, but i tried this error boundary catching with simple cache provider yesterday and it didnt work at all. just says unhandled rejection. im wondering if they havent shipped error boundaries that can handle this yet.

[pomber]

I just tested it with simple-cache-provider and got the same result as you, the error boundary didn't catch it. I've read that react 16.3 included a rewrite of error boundaries, maybe the alpha version we are using doesn't have that code merged.

[tsiq-swyx]

ah ok so at least im not fundamentally misunderstanding something. thanks very much! keeping a close watch on this one. i def think the debugger belongs in react devtools eventually

[pomber]

@tsiq-swyx looks like handling rejections was missing: facebook/react@75048c2

[tsiq-swyx]

awesome! I dont know how you find this stuff. but thanks a lot for sharing it!

…

On Tue, Apr 17, 2018 at 10:28 AM, Rodrigo Pombo ***@***.***> wrote: @tsiq-swyx <https://github.com/tsiq-swyx> looks like handling rejections was missing: ***@***.*** <facebook/react@75048c2> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AiT1gqYUlTcwnWugcApU6ZbTmLr__tclks5tpfwagaJpZM4S76PT> .