Comments (12)
@arrowtype @outoftime If you're cool with adding a "Format Code" button to the hamburger I can open up a PR today. It would look something like this:
from popcode.
@arrowtype I'm the maintainer of Popcode but at the moment I only have bandwidth for KTLO and reviewing submissions from others—would recommend polling fellow volunteers for someone fairly comfortable in React and Redux, with that technical grounding this should not be a heavy lift.
As for UI, I agree that a button tied to each of the language headers would be ideal, but I think a modest rethink of the editor header layout would make that a lot easier. (There were some nice looking designs kicking around a while ago but they were never implemented).
As a done-is-better-than-perfect solution, we could just add an entry to the hamburger menu. (I think I would actually prefer this over a button in the primary header—we really don't want that space to feel cluttered or overwhelming).
from popcode.
Thanks for the quick response and feedback, @outoftime!
Okay, I'll share this in Slack to see whether anyone might be able to take it on.
we could just add an entry to the hamburger menu. (I think I would actually prefer this over a button in the primary header—we really don't want that space to feel cluttered or overwhelming).
Good points – I definitely want to avoid adding too much clutter. But also, I'm unsure about putting this the hamburger. So far, that acts a bit like a container for "admin" stuff (add instructions, send feedback) or links to social media. The header seems to maybe be logical, because it has functions that manipulate the code in some way (adding libraries, changing font size). Though yes, probably a quick solution would be fine, and longer-term a redesign might be helpful.
from popcode.
Here is the PR with the design tweaks (which I still like!): #1245
from popcode.
So far, that acts a bit like a container for "admin" stuff (add instructions, send feedback) or links to social media. The header seems to maybe be logical, because it has functions that manipulate the code in some way (adding libraries, changing font size). Though yes, probably a quick solution would be fine, and longer-term a redesign might be helpful.
Right—the only intended organizing principle of the hamburger menu is that of a “junk drawer” for functionality that doesn't have an obvious home elsewhere. Youʼre right that it tends to be administrative stuff but thatʼs by happenstance, not design. Ultimately I am not too worried about discoverability since students get lots of direct instruction on how to use Popcode.
from popcode.
Hmm, that does look like a promising design update. Yes, those sub-header bars is probably the place to put it, especially if it prompts users to fix formatting issues!
Fair point on the junk drawer. And yes, students probably would only need to hear it once and they'd have it.
Somewhat-related question: are there other shortcuts in Popcode?
from popcode.
@adrianfalleiro Iʼm down!
from popcode.
@adrianfalleiro Love it! This would be a perfect quick fix. I would almost say that this is a more frequent action than the others, so it might be worth sorting first in the list. But, I defer to @outoftime on that.
from popcode.
I have no opinion on the internal organization of the junk drawer 😃
from popcode.
PR: #2382
from popcode.
@arrowtype This feature has been shipped so I think we're good to close this issue.
from popcode.
Yes, it looks good to me, and seems to work well! Can't wait to tell the students that it's there now. Nice work, @adrianfalleiro!
from popcode.
Related Issues (20)
- Support camera API in previews
- Cannot read property 'toString' of undefined HOT 4
- Cannot read property 'toString' of undefined HOT 1
- Bug: Popcode console is not updating with console.log or errors HOT 8
- User Feedback
- Can't log in with Google HOT 1
- Toggle multiline comments in editor with cmd-/ HOT 5
- User Feedback
- e.SHEBANG is not a function
- Backtick in CSS causes UI to crash HOT 1
- User Feedback
- The user denied permission to use Service Worker.
- HTML, CSS and JS Tabs (still) obscure first two lines HOT 1
- Page title bar overflows and has odd sizing behavior on small and/or zoomed screens HOT 1
- User Feedback
- <h1> within <p> causes following closing tags to turn red
- Add support for CSS property object-fit
- 401 unauthorized error when trying to export to Github from Popcode
- Diaeresis marks on international keyboards cause an error. A warning message might be more appropriate.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from popcode.