Weird thing is happening with subtitle time settings about popcorn-android

[mathieuzen]

Managed to find a workaround when running on the nexus player (i was unable to delay subtitles before that) by using an EditText widget instead of NumberPicker in NumberPickerDialogFragment.java as shown below:

import android.widget.EditText;

...

@Override
public Dialog onCreateDialog(Bundle savedInstanceState) {
    AlertDialog.Builder builder = new AlertDialog.Builder(getActivity());

    if (getArguments() == null || !getArguments().containsKey(TITLE) || mOnResultListener == null) {
        return builder.create();
    }

    final EditText numberPicker = new EditText(getActivity());

    final int currentValue = getArguments().getInt(DEFAULT_VALUE);

    builder
            .setView(numberPicker)
            .setTitle(getArguments().getString(TITLE))
            .setPositiveButton(R.string.ok,
                    new DialogInterface.OnClickListener() {
                        @Override
                        public void onClick(DialogInterface dialog, int which) {
                            mOnResultListener.onNewValue(Integer.parseInt(numberPicker.getText().toString()));
                            dialog.dismiss();
                        }
                    })
            .setNegativeButton(R.string.cancel,
                    new DialogInterface.OnClickListener() {
                        @Override
                        public void onClick(DialogInterface dialog, int which) {
                            dialog.dismiss();
                        }
                    }
            );

    return builder.create();
}

then rebuild the apk and install to get this (not so nice though but it works):

[imurreflection]

Hi mate, I know its quite late to ask this question but looking at the response above, I can see that you are the man. Please help, I have been requesting these developers for a long time but its of no use. All I am looking for is to include subtitles position in subtitles settings as they kind of come in between movie and its like hell. Please help me or teach me how to accomplish this task as I m sure these people will never listen. Please help

[team-pct]

This issue was moved to https://discuss.popcorntime.sh/t/weird-thing-is-happening-with-subtitle-time-settings/111