Converting <code> blocks to Flems about flems

[tormodvm]

Yes, sorry, it should be false. My bad. Hope that solved your problem.

[porsager]

Yeah the thinking was exactly for a case like this where replacing code blocks with actual working code would keep the layout as expected.. I'll try to see why it's not behaving correctly now..

[porsager]

Nono, I was already fixing other small issues in the same area, so it's perfect to look at now ;)

[tormodvm]

autoHeight makes the flems container height 100% of it's parent.
It doesn't work inside <code> , because code is display: inline by default.

This css: code { display: block; height: /* whatever */ } will make height work.

[mike-ward]

The container changes height but Flems is still squashed

[mike-ward]

Setting autoHeight = false allows the content fill to the size of the container.

[porsager]

autoHeight: true was supposed to set the height to show the entire content of the first selected file, but it appears there's a bug, and that it just ends at the minHeight value.

[tormodvm]

Ah, I see. Never understood the logic, but now I do. :)

[mike-ward]

Trying not to be a pest but any progress on this issue?

[porsager]

Oh sorry mike, I hadn't given it any priority since I thought the static height was ok for you for now.. I'll try to look into it right away ;)

[porsager]

Just to be sure, the functionality that isn't working is for it to set it's height to show the full code of the initially selected file. That's also the thing you're needing right?

[mike-ward]

Yep, that's it.

Static height is working, just not optimal.

If you got something else pressing I can certainly wait.

[porsager]

Hi @mike-ward I got caught up with some other fixes and improvements, but autoHeight should work now. Let me know if everything works as you expected ;)

[mike-ward]

Awesome! Check it out at http://mike-ward.net/2018/05/09/mithril-rising/

[porsager]

Yay.. that's great.

Maybe a max-height of somewhere between 600-800 would be good generally though?

[mike-ward]

I'm OK with no max height.