porsager / pws Goto Github PK

I noticed there was a new release in npm, v4.0.6, but when i came to the repository to see the changes i didn't see them and saw the package.json is still 4.0.5, any reason for not updating the repository?

So i found this module which is exactly what i need, but it looks like the ws options won't be passed correctly unless you pass a parameter for protocol, i found out this while testing, i kept getting "401" when trying to connect and after that, i decided to check the headers of the request, the "authentication" header was missing, until i added a empty and not empty string as the second parameter (protocol) and the header was included in the request.

request that didn't work:

const ws = Pws("ws://localhost:9090", Websocket, {
    headers: {
        authentication: "test"
    }
});

request that worked:

const ws = Pws("ws://localhost:9090", "", Websocket, {
    headers: {
        authentication: "test"
    }
});

The exposed interface does not allow to use ws options so it is not possible, for example, to disable CPU intensive extensions like permessage-deflate.

I am using the pingTimeout option and when the server does not send a message in a while, just as pws is about to close the connection, it crashes with “Cannot assign to read only property 'code' of object '#'”

Chrome 73.0.3683.103, but MDN agrees that the property is read-only.

According to the documentation on the readme of this repo,

To prevent this state PWS let's you set a specific timeout after which to force a reconnection if you did not receive any messages from the server.

However, what I observe is that if I set pingTimeout, the socket connection closes after that amount of time and does not re-connect.

Is there a way to use this without node?

This is very useful when connection is aborted and you are trying to send something unsuccesfully. Until connection is open again, all data are buffered and will be sent once reconnection happened

I set the "maxRetries" option to N. But after reaching maximum retry it keeps retrying. I found the bug in the code.

I think this line is the issue -