GithubHelp home page GithubHelp logo

Comments (24)

w0rm avatar w0rm commented on June 6, 2024

@sqal which version of gulp-sass do you use?

from gulp-postcss.

sqal avatar sqal commented on June 6, 2024

@w0rm 2.0.1. But is sass version relevant here? Sourcemaps only does not work with postcss in the task, as I mentioned before.

from gulp-postcss.

w0rm avatar w0rm commented on June 6, 2024

@sqal it may be, if the relative file name doesn't match the one specified in the sourcemap that is coming from the sass, then sourcemaps won't be combined.

from gulp-postcss.

sqal avatar sqal commented on June 6, 2024

Hmm OK. But i also tested it with only one scss file, outcome was the same - postcss breaks sorucemaps :(

from gulp-postcss.

w0rm avatar w0rm commented on June 6, 2024

Probably this is connected with dlmanning/gulp-sass#106

from gulp-postcss.

w0rm avatar w0rm commented on June 6, 2024

@sqal can you create a minimal project that reproduces this issue?

from gulp-postcss.

ai avatar ai commented on June 6, 2024

Maybe this issuw is relevant to postcss/autoprefixer#453

from gulp-postcss.

w0rm avatar w0rm commented on June 6, 2024

@ai my idea is to check that file.relative and file.sourceMap.file are the same after gulp-sass, otherwise source maps won't be properly combined by vinyl-sourcemaps-apply.

Perhaps a glob pattern app/styles/**/*.scss sets a different file.base, but gulp-sass doesn't take this into account when generating source map.

from gulp-postcss.

sqal avatar sqal commented on June 6, 2024

@w0rm here you go: https://github.com/sqal/gulp-postcss-issue-40

from gulp-postcss.

w0rm avatar w0rm commented on June 6, 2024

Awesome, thanks, I'll look into it tonight

On 26 May 2015, at 09:39, sqal [email protected] wrote:

@w0rm here you go: https://github.com/sqal/gulp-postcss-issue-40


Reply to this email directly or view it on GitHub.

from gulp-postcss.

w0rm avatar w0rm commented on June 6, 2024

@sqal works perfectly fine for me https://yadi.sk/i/GsfUZ1OJgtKDt

from gulp-postcss.

sqal avatar sqal commented on June 6, 2024

@w0rm That's weird. This is what it looks like to me:

Why I don't have path to .scss file but .css? however i can still edit .scss file in sources panel (chrome), doesn't work in Firefox at all. I think this is not working properly, right?

from gulp-postcss.

w0rm avatar w0rm commented on June 6, 2024

@sqal maybe it is a limitation of Firefox or has something to do with how browserSync does its live updates. The source map is generated properly.

from gulp-postcss.

w0rm avatar w0rm commented on June 6, 2024

Closing this, because live updates and browser edit features are not related to gulp-postcss, and the correct sourcemap file is generated.

from gulp-postcss.

sqal avatar sqal commented on June 6, 2024

Hmm.. but this is what it looks like in FF when gulp-postcss is on http://prntscr.com/79perd (can't edit scss), and this is when it's off (can edit) http://prntscr.com/79pgcq am i wrong or not? because to me looks like something doesn't work correctly after all.

from gulp-postcss.

w0rm avatar w0rm commented on June 6, 2024

@sqal cannot see your screenshots.

from gulp-postcss.

sqal avatar sqal commented on June 6, 2024

@w0rm Sorry for that..

with gulp-postcss - https://www.dropbox.com/s/0tkv2ow9clfr6zm/LRR32yD.png
without - https://www.dropbox.com/s/drpadlxvxsdl4xm/Zs4Yfy0.png

from gulp-postcss.

w0rm avatar w0rm commented on June 6, 2024

@sqal since its working in Chrome, might be a Firefox issue.

I downloaded recent Firefox, tried to reproduce, but couldn't. Screencast: https://yadi.sk/i/5D9I3FxtgtQWs

from gulp-postcss.

sqal avatar sqal commented on June 6, 2024

@w0rm I have the latest version of Firefox. Maybe this is Windows related issue? Perhaps someone with Windows 7 can confirm this issue?

from gulp-postcss.

w0rm avatar w0rm commented on June 6, 2024

@sqal sorry I can't help you with this.

If you want to verify source maps, remove browserSync, generate style.css and style.css.map, link to the css from a static html file, then open html file in the browser.

If you don't see scss there, then you have style.css and style.css.map that are not working in your version of Firefox.

from gulp-postcss.

sqal avatar sqal commented on June 6, 2024

@w0rm browser-sync has nothing to do with that, gulp-postcss seems to be still the problem, but all right, I give up on this.Thank you for your time anyway :)

from gulp-postcss.

w0rm avatar w0rm commented on June 6, 2024

If you have just three files, test.html style.css and style.css.map, then this might be reduced test case for the Firefox.

from gulp-postcss.

w0rm avatar w0rm commented on June 6, 2024

@sqal I might give it a try tomorrow. Will try to download windows7 from modern.ie.

from gulp-postcss.

w0rm avatar w0rm commented on June 6, 2024

@sqal I can see app.scss in the recent Firefox for Windows 7.

screen shot 2015-05-27 at 20 06 58

from gulp-postcss.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.