GithubHelp home page GithubHelp logo

Comments (8)

potatosalad avatar potatosalad commented on August 22, 2024 5

@doughsay Yes, I'll have a new release out soon.

In the meantime, you should be able to override the dependency in your mix.exs file:

{:base64url, "1.0.1", override: true},

from erlang-jose.

Qqwy avatar Qqwy commented on August 22, 2024

Would there be any reason to keep the dependency, now that Elixir provides this itself?

from erlang-jose.

victorolinasc avatar victorolinasc commented on August 22, 2024

@Qqwy just giving my opinion here: JOSE is used a lot on other BEAM languages too. Perhaps, what would make more sense is to update the base64url library with the generated Base version from Elixir.

@potatosalad if that makes sense I could try to make this PR (updating the base64url dep). Thoughts?

from erlang-jose.

Qqwy avatar Qqwy commented on August 22, 2024

@Qqwy just giving my opinion here: JOSE is used a lot on other BEAM languages too. Perhaps, what would make more sense is to update the base64url library with the generated Base version from Elixir.

Regardless of what BEAM language is using JOSE, when compiled, JOSE will include a compiled version of the Elixir standard library, so Base will be included, therefore making the base64url dependency superfluous, right?

from erlang-jose.

victorolinasc avatar victorolinasc commented on August 22, 2024

@Qqwy I think it is quite possible to compile JOSE without Elixir. I haven't looked deep enough to be sure, but when using it as a dependency in a purely rebar project or using erlang.mk it does not "mandate" Elixir to be present. Not sure and maybe I'm just saying nonsense here... Sorry for the noise otherwise!

from erlang-jose.

Qqwy avatar Qqwy commented on August 22, 2024

@victorolinasc You might very well be right; I mistakenly thought all of JOSE was written in Elixir, but this is not true: there is an Elixir wrapper (in lib), but the base library is written in Erlang (in src).

👍 Thank you for correcting me!

from erlang-jose.

potatosalad avatar potatosalad commented on August 22, 2024

I'm experimenting with bundling jose_base64 and jose_base64url modules with jose itself on the develop branch.

I think bundling a deterministic JSON encoder/decoder would also be wise so that the project is a little closer to zero dependency.

from erlang-jose.

doughsay avatar doughsay commented on August 22, 2024

Any progress on this?

Because jose 1.9.0 still depends on base64url 0.0.1, we are forced to manually install rebar2 in our build process just for this one dependency. Can we at least get a release of jose that uses base64url 1.0.1 so we can stop using rebar2?

Thanks!

from erlang-jose.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.