Comments (6)
We use it in the cases where we want to notify the user of an error, but it's impossible to actually return an error (e.g. a TypeError in a map function and the user set update_after=true
).
If you set db.on('error', function (error){/* do something */}
, then you can handle the error. Else it will just throw an exception where possible, which is why we were setting db.on('error', function (error){/* noop */}
in the tests.
from mapreduce.
So I suppose I've broken that functionality.
from mapreduce.
Yeah, but that was my bad for not writing a test for it. I believe you just need to change the /* noop */
to confirm that an error was emitted.
from mapreduce.
Still wondering what to do with this line:
Line 13 in ba53406
from mapreduce.
Presumably it is impossible for an error to be thrown there, since we're putting try/catch around any user code. If an error is thrown, then it's a bug.
So I believe you should be able to remove that implicit "catch" and the tests will still pass.
from mapreduce.
Closing in favour of #126.
from mapreduce.
Related Issues (20)
- CommonJS requires inside map functions HOT 3
- No error or warning raised when calling a query with an unknown filter HOT 2
- Custom replacement for eval() HOT 13
- Bring back the in-memory temp views HOT 11
- 2.2.7 HOT 1
- phantomjs is green even when cannot connect to selenium HOT 3
- Mapreduce 2.3.0
- Don't need to fetch the remote design doc HOT 1
- Dependent dbs not properly destroyed for MemDOWN in Node HOT 3
- One queue per view HOT 2
- Perf: don't fetch local docs if rev is "1-" HOT 2
- Many unsafe Object key usages HOT 2
- Test PouchDB Server in travis HOT 4
- InvalidStateError when using `update_after` HOT 2
- Remove PouchDB.destroy usage HOT 1
- use selenium-standalone HOT 1
- Release 2.3.2 HOT 1
- 2.3.3
- Deprecate repo and move issues? HOT 5
- Lock issue.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mapreduce.