emit('error') about mapreduce

[nolanlawson]

We use it in the cases where we want to notify the user of an error, but it's impossible to actually return an error (e.g. a TypeError in a map function and the user set update_after=true).

If you set db.on('error', function (error){/* do something */}, then you can handle the error. Else it will just throw an exception where possible, which is why we were setting db.on('error', function (error){/* noop */} in the tests.

[neojski]

So I suppose I've broken that functionality.

[nolanlawson]

Yeah, but that was my bad for not writing a test for it. I believe you just need to change the /* noop */ to confirm that an error was emitted.

[neojski]

Still wondering what to do with this line:

mapreduce/taskqueue.js

Line 13 in ba53406

// just recover

[nolanlawson]

Presumably it is impossible for an error to be thrown there, since we're putting try/catch around any user code. If an error is thrown, then it's a bug.

So I believe you should be able to remove that implicit "catch" and the tests will still pass.

[neojski]

Closing in favour of #126.