GithubHelp home page GithubHelp logo

Comments (6)

poudink avatar poudink commented on September 25, 2024

This is especially bad in Maui applications. Almost every icon is made monochromatic. Some applications become very difficult to use, since these icons weren't exactly intended to be seen as simple silhouettes, making it difficult to distinguish buttons from one another, as many of them lack labels.

from plastik.

poudink avatar poudink commented on September 25, 2024

https://invent.kde.org/frameworks/kirigami/-/commit/66c6a75d44353c15101d872396be66b92d1c33e6

Should be fixed in Frameworks 5.107. 5.106 was just released, so I imagine there's still a long time to go until the release. Will be closing once it happens.

from plastik.

poudink avatar poudink commented on September 25, 2024

Looking at the commit, this is only going to solve cases where we're not using a symbolic-suffixed icon but the app wants a symbolic-suffixed icon, so the app treats our non-symbolic icon as a symbolic icon.

This won't fix cases where we're using a symbolic-suffixed icon that isn't actually symbolic, which we need to do because GTK apps won't fallback to the non-symbolic version and will instead fall back to Breeze.

from plastik.

poudink avatar poudink commented on September 25, 2024

Wait, now I'm confused. The issue I linked in this issue was closed by the PR mentioned above, even though it seems to be pertaining to the cases my last comment just says wouldn't be fixed. Also, I was wrong. Frameworks apparently releases monthly, so 5.107 will happen quite soon in June. I thought it was on an triannual schedule similar to KDE Gear and Plasma.

from plastik.

poudink avatar poudink commented on September 25, 2024

So, I thought this was a problem universal to Maui applications, but it turns out it isn't. I just tried out the new Bonsai, Fiery and Strike applications from the recent Maui 3.0 release and the icons in them are being displayed correctly. I took a second look at some of the older Maui applications and it turns the problem is actually far from universal, though it is definitely more common than it is in regular Kirigami applications.

from plastik.

poudink avatar poudink commented on September 25, 2024

Upgraded to 5.107 and as I thought this hasn't been completely fixed. It seems sidebars are the problem. Like the ones in Alligator, AudioTube or Index.

from plastik.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.