GithubHelp home page GithubHelp logo

Comments (4)

danschultzer avatar danschultzer commented on May 26, 2024

Yeah, that makes sense.

Currently Assent OAuth 2.0 strategy only supports authorization code grant flow. I'm not sure if this is implicit grant flow, but I'll dig into the facebook docs to see how I should deal with the callback phase.

from assent.

danschultzer avatar danschultzer commented on May 26, 2024

So it looks like this would be specific to facebook instead of implicit grant flow:

https://github.com/simi/omniauth-facebook/blob/48cdde26c5fffab4fcc0f2a27e88601b245c0b9b/lib/omniauth/strategies/facebook.rb#L127-L151

https://github.com/facebookarchive/facebook-php-sdk/blob/8e7e7951e99d86b68ce1135537d559663d759af0/src/base_facebook.php#L477-L491

As I understand it, this decodes the short lived access token from a cookie using the client secret, and then uses it to generate a long lived access token. Not sure if necessary with Assent, but I guess it can't hurt.

Edit: Facebook also suggests using code grant flow https://developers.facebook.com/docs/facebook-login/security#codeflow. I'll have to test this manually to see how it all works.

Also, this lib is probably the best reference: https://github.com/facebook/php-graph-sdk/blob/6d1eb5a3861624cd0ff40c67e517de891d78134a/docs/reference/FacebookJavaScriptHelper.md

from assent.

danschultzer avatar danschultzer commented on May 26, 2024

I've set up instructions for how to deal with Facebook JS SDK here: #44

from assent.

danschultzer avatar danschultzer commented on May 26, 2024

I'll close this as I believe both #44 and changes in the OAuth 2.0 strategy has made it very easy to handle with already fetched access token in client.

To recap:

  1. The Facebook strategy docs now highlights how to fetch the code client side to submit server side
  2. The Assent OAuth 2.0 strategy now supports any grant type with Assent.Strategy.OAuth2.get_access_token/3 to fetch the access token. Callback still uses the authorization code flow.
  3. Assent.Strategy.Facebook.get_user/2 could be used to fetch the user data with the access token.
  4. Passing an access token straight to the backend is not recommended unless you reverify: https://developers.facebook.com/docs/facebook-login/web/accesstokens#confirm There might need to be a special method in the facebook strategy to handle this case, as I believe this is a facebook feature and not part of the oauth2 specs.

from assent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.