is this lib compatible with HipChat enterprise? about hipchat-scala

[poweld]

This sounds like a good addition. I can't promise to review it until the weekend, so take your time with the PR. It looks like you're on a good track in your proof of concept.

[pedrorijo91]

It is possible (and easy) to override the default api-url by adding the config to an application.conf file as stated at https://www.playframework.com/documentation/2.4.x/ProductionConfiguration#General-configuration

unfortunately this is not practical if we want to have "clients" for different instances in the same application.

I could do a PR which would allow to pass a base url explicitly, for instance something like:

class RoomNotifier(private[this] val apiToken: String, baseUrlOpt: Option[String] = None)(implicit executor: ExecutionContext) extends Logging {

  (...)

}

object RoomNotifier {
  val instanceUrl = baseUrlOpt.map(Common.url)
  private def url(roomIdOrName: String) = (instanceUrl.getOrElse(apiUrl) / "room" / roomIdOrName / "notification").POST
}

Let me know your thoughts about this

[pedrorijo91]

Proof of Concept here: master...pedrorijo91:feature/customApiURL

Still need to test it, and there are probably some minor improvements to be done, and maybe other code style issues you'd prefer different. I will have a better look at my code tomorrow before doing a PR. In the meanwhile let me know if you find something you disagree :)

[pedrorijo91]

thanks for the heads up @poweld. I did the PR #23 this morning, let me know your thoughts when you find the time :)