GithubHelp home page GithubHelp logo

Comments (6)

joeyaiello avatar joeyaiello commented on June 8, 2024

My suggestion is that, until an RFC reaches either Accepted or Experimental status (somewhat ambivalent as to which one is the gate; others may not be), it should only exist as a pull request from another branch. This way, people can comment on the RFC on a line-by-line basis as opposed to either forking, editing, and pull requesting, or referring to line #s on the associated Issue. (There's also the added benefit that I don't lose all my comments when working a little bit at a time in a browser window.)

From there, I think the Issue should be generated once the pull request is accepted (again, after it reaches either Accepted or Experimental.) There you can track comments on RFCs that are already in flight.

Alternatively, we could just require that people spin up an Issue for every problem that they have with an RFC, but that could be a bit too noisy.

Thoughts?

from powershell-rfc.

vors avatar vors commented on June 8, 2024

sounds reasonable

from powershell-rfc.

JamesWTruher avatar JamesWTruher commented on June 8, 2024

We need to be sure that these RFCs don't wither on the vine. I think that part of the process should clearly mandate a time frame for comments - for example: Comments will be accepted until < date >. We need to describe timelines and closure actions in every RFC.

from powershell-rfc.

vors avatar vors commented on June 8, 2024

We want to cover two main scenarios:

  1. Gathering feedback about a new text
  2. Continue gathering feedback about an existing text

We can address them in the same manner or differently.
I propose to use "PR+comments for PR" for (1).
Then, when PR is merged, we open an issue with the corresponding name to address (2).

from powershell-rfc.

SteveL-MSFT avatar SteveL-MSFT commented on June 8, 2024

@JamesWTruher added verbage in Process that typically we want to allow 2 months for comments. added due date to Mutual Exclusion doc as example

from powershell-rfc.

SteveL-MSFT avatar SteveL-MSFT commented on June 8, 2024

Feedback addressed

from powershell-rfc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.