Get-InvalidArgumentRecord params should match New-InvalidArgumentException about psdscresources

[PlagueHO]

@kwirkykat - oh wow! Cool! I didn't know this.

I only ever test the error message on the exception object anyway, so IMHO we should get rid of it - simpler is better I think.

I think so far I've only used this function in FSRMDsc and FileContentDsc (work in progress). So removing it for me wouldn't be too difficult. If you decide to remove it, let me know and I'll do the same in the above resources because I'd prefer to keep in line with PSDscResources.

[kwirkykat]

Closing this issue since this function was removed

[PlagueHO]

It would also be awesome if this also applied to Get-InvalidOperationRecord as well. And I think these should both be in CommonTestHelpers.psm1 rather than in the helper module for the specific tests.

The reason I suggest this is that I'm trying to ensure all resources I work on match what you're doing with PSDscResources. So I'm copying and including these modules in the repos.

Hope that makes sense!

[kwirkykat]

@PlagueHO While I was working on ServiceSet, I found that this function wasn't actually necessary since you can just check for the correct error message in Pester without the entire error record as you can see here.

So I've actually taken this function out in my most recent code. Do you think it's worth it to keep it?