GithubHelp home page GithubHelp logo

Request: Register-SecretVault should call Test-SecretVault of the implementing extension in host UI Thread about secretmanagement HOT 4 CLOSED

powershell avatar powershell commented on May 29, 2024
Request: Register-SecretVault should call Test-SecretVault of the implementing extension in host UI Thread

from secretmanagement.

Comments (4)

issue-label-bot avatar issue-label-bot commented on May 29, 2024 1

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.74. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

from secretmanagement.

SydneyhSmith avatar SydneyhSmith commented on May 29, 2024 1

Thanks we are going to close this as by design

from secretmanagement.

SydneyhSmith avatar SydneyhSmith commented on May 29, 2024

@JustinGrote we made the choice to separate the Testing of the vault from Registration in order to facilitate debugging (you may not want registration to fail just because the vault isnt currently available)...would love to hear more about why this would be useful though!

from secretmanagement.

JustinGrote avatar JustinGrote commented on May 29, 2024

@SydneyhSmith I feel this is something that can be left up to the extension author in = VaultParameters, for instance an extension can have "Offline" VaultParameter to skip parts of the check if that offline registration is required. Maybe instead of it calling Test-SecretVault directly it could be a separate function like Test-SecretVaultIsValid that is specifically related to that piece so test-secretvault still always assumes it is onlin

Otherwise my workaround is sufficient in that I just call Test-SecretVault at the top of every other function :)

from secretmanagement.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.