GithubHelp home page GithubHelp logo

Rename the `default` feature to `base` about pixi HOT 6 OPEN

zen-xu avatar zen-xu commented on July 30, 2024 1
Rename the `default` feature to `base`

from pixi.

Comments (6)

ruben-arts avatar ruben-arts commented on July 30, 2024 1

I don't think the environment should be named base as it is not acting as a basis for any other environment, because you can override it to be the most inclusive environment. e.g. default = {features = ["test", "dev", "cuda"], solve-group = "default"}.

However, this change would make more sense to me for the default feature. This is used as a basis for all environments and has to be deactivated by adding no-default-feature which could be no-base-feature.

That said we've chosen for "default" as it is what cargo uses to define the "normally activated" features. So I'm not 100% convinced this would be worth the change.

from pixi.

zen-xu avatar zen-xu commented on July 30, 2024 1

However change would make more sense to me for the default feature.

🤦🏻‍♂️ Sorry for my incorrect description. It should be the feature,not the env.

from pixi.

zen-xu avatar zen-xu commented on July 30, 2024

Furthermore, the naming meaning of base is superior to default; it's like the foundation of a feature, with each feature adding extra dependencies on top of it.

from pixi.

tdejager avatar tdejager commented on July 30, 2024

I suggest we keep this open for a while to see how others feel about it :) As it would be a breaking change.

from pixi.

olivier-lacroix avatar olivier-lacroix commented on July 30, 2024

I feel like default is a pretty good name even for the feature:

  • it aligns with the name of the default environment
  • It is the feature tables / values will be associated with when the feature is not specified. In that sense, it is indeed the default feature

from pixi.

zen-xu avatar zen-xu commented on July 30, 2024

I feel like default is a pretty good name even for the feature:

  • it aligns with the name of the default environment

  • It is the feature tables / values will be associated with when the feature is not specified. In that sense, it is indeed the default feature

You can think of default feature as the base image of Docker; we are extending its behavior rather than overriding it.

Or in the OOP inheritance, we refer to it as a base class rather than a default class.

That's why like channels is under the [project] rather than under the [default], it is because the actual default configs are under the [project].

from pixi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.