GithubHelp home page GithubHelp logo

Comments (3)

prestarocket avatar prestarocket commented on May 26, 2024

it is not handled by the theme but by ProductController and core.js: https://github.com/PrestaShop/PrestaShop/blob/1.7.4.x/controllers/front/ProductController.php#L398

from classic-rocket.

mortenhartvig avatar mortenhartvig commented on May 26, 2024

Blinking images on a white background is bad for everything, including - and not limited to - epilepsy:)

It's not a bug/feature in "native", because it becomes a bug/feature when you add lazy-loading the way this theme does. I currently use lazy-loading with mod_pagespeed for a "prestashop_classic" fork, and even though it behaves worse, it dosn't flickr the images, as it checks if the file is the same before changing:)

Instead of replacing existing (loaded) images with the loading-spinner. Just append the spinner on top of the existing (loaded) image with a higher z-index or similar solution, where you don't replace an image with a blank background.

Please, for the sake of epilepsy, and UX in general. :)

I may add it at some point and do a pull-request/fork, when i update my production shop to 1.7.4.x, but that may take months due to no time.

from classic-rocket.

prestarocket avatar prestarocket commented on May 26, 2024

i'm not sure to understand your point but i can remove lazyloading only for the first product img (it s always in the viewport) in order to remove this blinking effect; what do you think about it ?

from classic-rocket.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.