Comments (7)
These untracked files are from the #22645 (but they were not added by the PR, the PR removed them from the sources):
presto-main/src/main/resources/webapp/dev/query_viewer.js
presto-main/src/main/resources/webapp/dist/
@ZacBlanco also informed me about this issue
The possible solutions are:
- Add these files into .gitigonre
- Modify the webpack to generate compiled JS to
presto-main/target
directory
For solution 2, it may need to tweak the webpack config to cover the dev scenarios. Need to make sure yarn watch
, yarn serve
work with the new JS location.
from presto.
#1 is not really a solution. #2 is a maybe. In the past I've seen these sorts of tools use a generated-sources directory though at the moment, I can't find any docs about that. However we definitely should not generate anything into src/main. We need to put generated code somewhere mvn clean
will delete it.
from presto.
We need to put generated code somewhere mvn clean will delete it
That's option 2.
from presto.
had to look in the maven-compiler-plugin source code but it likely belongs in
${project.build.directory}/generated-sources/
from presto.
FYI, Presto is following the Maven stadnard directory layout: https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html
from presto.
Yes, and nothing in that layout is for generated code.
from presto.
for .js
files, they are equal to .class
which would go to target/classes
from presto.
Related Issues (20)
- Consider combining AbstractVariableWidthBlock and VariableWidthBlock HOT 1
- Change OrcBatchPageSource.isRowNumberList to IntOpenHashSet or boolean[]
- Add Presto sidecar process type
- Presto CLI console printer cannot handle UTF-8 characters
- HiveColumnHandle should be able to recognize row numbers
- ImmutableList.of() --> Collections.emptyList() HOT 11
- Update home page Readme to include setup and general info/benchmarks about Presto HOT 1
- Security Vulnerability Detected in org.eclipse.jetty packages
- Security Vulnerability in guava
- Flaky CI behaviour due to 'yarn' failed HOT 1
- Upgrade Jetty Version to Align with Airlift HTTP Client and Server Updates to Address Security Vulnerabilities
- IcebergDistributedSmokeTestBase.testRegisterTable is flaky
- [Native] The "Extra Credentials" API is not available to Prestissimo/Velox connectors HOT 9
- Opinion on primitive block implementation with chunks instead of a single value arrays HOT 2
- Release 0.288
- presto-main suite failed with Could not download Node.js HOT 3
- TestIcebergSmokeRest AbstractTestIntegrationSmokeTest.testSelectInformationSchemaColumns flaked HOT 1
- Clarify Presto C++ documentation to include required coordinator configuration properties HOT 1
- Abnormal data display when using offset and limit HOT 2
- Issue while initializing Database based Resource Group Manager
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from presto.