GithubHelp home page GithubHelp logo

Comments (8)

tdcmeehan avatar tdcmeehan commented on July 25, 2024 1

We typically update Joda, and mention in the release notes that a corresponding upgrade in the Java runtime is required (and also mention how to update that). Here's an example: #21329

from presto.

elharo avatar elharo commented on July 25, 2024 1

It probably depends on which chunk of code is running. There's an outstanding task to move away from Joda to java.time, and interestingly the PR i just sent out to do part of that seems to have uncovered a bug in the JDK.

from presto.

pedroerp avatar pedroerp commented on July 25, 2024 1

Maintaining backwards compatibility will likely be an interesting challenge as you move away from joda. But regardless, in the short-term it would be nice if we could bump joda's version to align with results we get from the native engine.

from presto.

mbasmanova avatar mbasmanova commented on July 25, 2024

cc: @rschlussel @tdcmeehan

from presto.

elharo avatar elharo commented on July 25, 2024

We really need to ditch joda time. In 2024 it isn't needed. I think I tried this a couple of years ago, and got blocked on the lack of support or reviews in presto-druid.

from presto.

elharo avatar elharo commented on July 25, 2024

Changing joda version changes tzdata which must match deployed JVM tzdata. Do not change this without also making sure it matches

from presto.

elharo avatar elharo commented on July 25, 2024

https://www.oracle.com/java/technologies/tzdata-versions.html

I'm not sure how we can match the tzdata since it will be deployed across different JVMs.

from presto.

pedroerp avatar pedroerp commented on July 25, 2024

I'm not sure how we can match the tzdata since it will be deployed across different JVMs.

What is the story there? Is the timezone information got form Joda directly, or from the JVM? Not sure why both would be needed.

from presto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.