Success format messages don't respect logLevel about prettier-eslint-cli

[kentcdodds]

Hmmmmm. I think that'd be fine. But I seem to remember someone having an issue with us using anything but stderr for logging off that nature. Maybe @osener and @denis-sokolov could share their thoughts.

[denis-sokolov]

Indeed we don’t respect the log-level and we should.

I don’t believe we respected it before 81f6542 either. We switched from console.log to console.error, we did not touch the logger that was added in #31.

@jackfranklin, for your needs you should do unix pipe redirection anyway: eslint-prettier-cli 2>/dev/null will hide diagnostic messages. Why bother with log level?

[jackfranklin]

@denis-sokolov that's fair, I didn't think of doing that. However I do think I should be able to achieve the same by setting log level to silent - to me that's more intuitive. I am happy to take a stab at the PR if you'd like, else feel free to go ahead and close :)

Thanks for all your work on this tool btw 🎉

[kentcdodds]

Thanks @denis-sokolov! Yeah, let's get a PR merged that not only preserves the stderr behavior but also honors the log-level. Probably wont be able to use logger because it uses stdout for everything except error (also it prefixes all messages and this one we wouldn't want prefixed) which wouldn't make sense to me. I think most folks like to see it by default, so what do you think we log it unless the log level is set to silent?

[jackfranklin]

Agree - so shall I leave the calls using console.error but wrap them in an if (logLevel is silent) type thing?

[kentcdodds]

That sounds perfect 👍

[jackfranklin]

PS: I still find it kinda weird that the success case still uses console.error but I'm willing to go with that ;)

PR coming at ya tonight or tomorrow 👍

[denis-sokolov]

@jackfranklin, if you find console.error weird, consider that it’s just a shorthand. From inside the Node program we can directly write to any of the standard outputs with process.stdout.write and process.stderr.write.

[jackfranklin]

@denis-sokolov I meant more in that I find it odd that there's a success message, and you use console.error to log it. I can understand why but it's a bit jarring on first glance! I'll get a PR in soon based on Kent's suggestions - thanks for your help clarifying :)

[kentcdodds]

It is a bit jarring, maybe as part of your PR you could add a short comment explaining why.