Flow parser removes line breaks about prettier-vscode

[zoontek]

No need, I found one: prettier/prettier#770

[CiGit]

There is currently no option to disable it for some file pattern.

The extension does not run on JSON language, it runs on javascript and javascriptreact as specified here
Prettier throws an error on JSON object files and thus, the extension shouldn't do anything (a log in the developer tool)

Is this issue about JSON betting prettified or about a feature request?

[zoontek]

It performs on JSON and sometimes on certain JS files, by removing empty lines breaks, which is super annoying :(

JS file:

JSON file:

[CiGit]

Do you have any other formatter installed (extension)? prettier does not remove single line breaks like on your JS file.

For the JSON file, removing lines is the behavior of vscode's embed formatter.

[zoontek]

I don't think. editor.formatOnSave is set to true, and when prettier-vscode is disabled, it doesn't do that. Very strange.

[CiGit]

About which file type are you speaking? Both?
Just to be sure about your JSON file. If you set "json.format.enable": false, in your settings, does it still happen ? This is the embed json formatter.

Can you try [email protected] with the command line on your JS file?

Can you also test with all extensions disabled but prettier ?

I'm unable to reproduce your problem with the JS file. With the JSON file I think this is the embed formatter.

[zoontek]

"json.format.enable": false does the trick for the JSON files 👍
I disable every extensions except this one, and still encounter the problem. But it doesn't appear when I use the babylon parser (only appear with the flow parser)

I'll just use the babylon parser for now. Thanks for your precious help! :)

[CiGit]

Still seems there is an issue tho. I cannot reproduce this issue with the flow parser and a minimal code. Is it possible for you to provide a minimal code which produce this error and your settings for prettier.
Note: I also tried with CRLF

[zoontek]

I isolate the bug. Here is the minimal setup to reproduce it:

// @flow

import React, { Component } from 'react';
import { connect } from 'react-redux';

class MyClass extends Component {
  render() {
    return <span>8€</span>;
  }
}
const mapStateToProps = (state, ownProps) => ({
  navigation: ownProps.navigation,
});
const mapDispatchToProps = (dispatch, ownProps) => ({});
export default connect(mapStateToProps)(MyClass);

It doesn't happen if I remove the € character, and seems not related to this plugin (does the same using prettier directly). I should create an issue on the prettier repo.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.