Results are different for prettier-vscode and prettier CLI about prettier-vscode

[CiGit]

Can you provide a minimal code example which shows this difference ?

[dKab]

The output of Format Document:

export default store => next => action => {
  const callAPI = action[CALL_API];
  if (typeof callAPI === "undefined") {
    return next(action);
  }

  const { endpoint, types } = callAPI;

  if (typeof endpoint !== "string") {
    throw new Error("Specify a string endpoint URL.");
  }
  if (!Array.isArray(types) || types.length !== 3) {
    throw new Error("Expected an array of three action types.");
  }
  if (!types.every(type => typeof type === "string")) {
    throw new Error("Expected action types to be strings.");
  }

  const actionWith = data => {
    const finalAction = { ...action, ...data };
    delete finalAction[CALL_API];
    return finalAction;
  };

  const [requestType, successType, failureType] = types;
  next(actionWith({ type: requestType }));

  return callApi(endpoint).then(
    response => next(
      actionWith({
        response,
        type: successType
      })
    ),
    error => next(
      actionWith({
        type: failureType,
        error: error.message || "Something bad happened"
      })
    )
  );
};

The output of prettier --write:

export default store =>
  next =>
    action => {
      const callAPI = action[CALL_API];
      if (typeof callAPI === "undefined") {
        return next(action);
      }

      const { endpoint, types } = callAPI;

      if (typeof endpoint !== "string") {
        throw new Error("Specify a string endpoint URL.");
      }
      if (!Array.isArray(types) || types.length !== 3) {
        throw new Error("Expected an array of three action types.");
      }
      if (!types.every(type => typeof type === "string")) {
        throw new Error("Expected action types to be strings.");
      }

      const actionWith = data => {
        const finalAction = { ...action, ...data };
        delete finalAction[CALL_API];
        return finalAction;
      };

      const [requestType, successType, failureType] = types;
      next(actionWith({ type: requestType }));

      return callApi(endpoint).then(
        response =>
          next(
            actionWith({
              response,
              type: successType
            })
          ),
        error =>
          next(
            actionWith({
              type: failureType,
              error: error.message || "Something bad happened"
            })
          )
      );
    };

Note how in the latter snippet
export default store => next => action => {
becomes splitet on several lines:

export default store =>
  next =>
    action => {

[CiGit]

On your screenshot, in vscode's settings, the left part shows the default settings. Yours are on the right ;-)

Will watch into this

[dKab]

@CiGit Yeah, sorry, you are right. There's nothing there related to prettier though...

[CiGit]

Was just to be sure.
I've a minimal reproduction on my side

s =>
  a => {
    let v;
  };

[CiGit]

(s => a => {
  let v;
});

is the output of prettier 0.21

The extension is bundled with [email protected]

$ cat extensions/esbenp.prettier-vscode-0.10.1/node_modules/prettier/package.json| grep '"version":'
  "version": "0.21.0"

@esbenp You will have to republish npm install before ;-)

[dKab]

So how does this work? Will extension update itself every time new version of prettier is released? Are you required to manually republish extension on every prettier release?

[CiGit]

Currently something like that. I don't know if @esbenp has a little script to publish on his side.
We have #39 awaiting to be able to use prettier from the workspace.

[esbenp]

Good news I have just published #39 which should enable VS Code to use the projects Prettier

[esbenp]

https://github.com/esbenp/prettier-vscode/releases/tag/0.11.0

[esbenp]

@dKab please let us know if this resolves your issue :-)

[dKab]

Do I need to do anything with the extension? I mean uninstall/install in order to get this fix?

[esbenp]

If you go to the extensions pane it should tell you that it has a new version

[dKab]

@esbenp It works now, thanks!

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.