TSX falls back to JS about prettier-vscode

[CiGit]

😕 Can you explain a little more what you mean ?
Prettier doesn't handle typescript.

[madslundt]

Yes sorry.

The problem is when formatting the document, using TSX, it formats the document like it was just vanilla JavaScript (I suppose). This make the types and interfaces fly around and doesn't look so good.

Example using TSX:
export class Todo extends React.Component <void, TodoState>
is formatted into
export class Todo extends React.Component < void, ↵ TodoState >

But if prettier doesn't handle TypeScript, this should maybe not be an issue here.

[CiGit]

This extension runs on Javascript and Javascript React. Have you (or any of your extension) set tsx files to be any of those two? I'm asking because I see a line break and I'm pretty sure the provided typescript formater doesn't insert those. Any other formatter installed ?

[esbenp]

@CiGit is it not because the extension only activates on javascript and javascriptreact? When doing typescript react I think VS Code sets the language to typescriptreact or something similar. So I think we just need to add that as a valid language

[CiGit]

We currently can't activate it on typescript. There is a WIP PR on prettier to be able to parse/print typescript.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.