pricetx / backup Goto Github PK

Thank you for the software. I have one small suggestion.

I don't think it's a good idea to have programs and configuration files in the same place. I suggest changing

source "${SCRIPTDIR}"/backup.cfg

to

source "${SCRIPTDIR}"/../lib/backup.cfg

Or better still allowing the location of the configuration file to be given as an argument.

Would it be possible to add the -l option to scp to limit the scp bandwidth?

What would be really sweet - but it would add to the complexity of the script - would be to support incremental backups between the monthly, weekly and daily backups to minimize disc usage network bandwidth.

Running "backup.sh" gives this error on Linux:

tar: You must specify one of the '-Acdtrux', '--delete' or '--test-label' options
Try 'tar --help' or 'tar --usage' for more information.

Why does deleteoldbackups.sh give this error:

/backups/bin/deleteoldbackups.sh: line 59: cd: /root/backups/: No such file or directory

/root/backups appears nowhere in my configuration file:

root@nigelhorne:/backups/bin# fgrep /root *
root@nigelhorne:/backups/bin# ls -l
total 20
-r-------- 1 root root 2184 Jul 24 14:14 backup.cfg
-rwxrwxr-x 1 root root 4318 Jul 24 14:16 backup.sh
-rwxrwxr-x 1 root root 5438 Jul 24 13:39 deleteoldbackups.sh
root@nigelhorne:/backups/bin#