DynaForm: disabled state not restored about primefaces-extensions

[Rapster]

Next time, even though your problem is explained in the forum, few lines explaining your problem would be better. It's an issue tracker, community expects to read issues and not random feedbacks of your problem 😉

[jxmai]

via 9c8a1f1

[pzoli]

I added modifications to showcase(disable visitor) and core (readonly). please view attached files. Oh, how can I add attachments?

[Rapster]

You can create a Pull Request 😉

[melloware]

In our showcase project you can simply create a PR following these instructions: https://help.github.com/articles/creating-a-pull-request/

[pzoli]

Sorry, just now I have not enough time. Can you push the changes, please? Best regards Zoltan

[pzoli]

showcase changes https://drive.google.com/file/d/12HyjXP4ZAcSteV0Y3SYx_RryboYngPKm/view?usp=sharing core changes for readonly https://drive.google.com/file/d/1-8U8ljZ7evgl9kozxU7aVVL60UM95xir/view?usp=sharing

[Rapster]

I'll the do the changes in core (although i'd like to find a better way to restore these properties as we can't simply add a new field every time an unsupported property is used (e.g disabled, readonly, style, styleClas etc.). I don't think showcase is needed though

[melloware]

Sorry I think I have to reopen this. It appears this has now broken the FluidGrid. I have a FluidGrid with disabled field. When I updated the form that contains the FluidGrid is leaving my component disabled even though in PF 6.2.4 it was re-evaluating properly to enabled. So its restoring the state. They both extend this AbstractDynamicData which is where this change was made.

[melloware]

To elaborate say I had this FluidGrid dyna item.

    <pe:fluidGridItem type="select" styleClass="select">  
        <div class="dynaFormLabel">  
            <p:outputLabel for="menu" value="#{data.label}"/>  
        </div>  
        <p:selectOneMenu id="menu" value="#{data.value}" required="#{data.required}" disabled="#{fluidGridDynaFormController.randomDisabled}">  
            <f:selectItems value="#{data.selectItems}"/>  
        </p:selectOneMenu>  
    </pe:fluidGridItem> 

once the form is submitted even if my disabled="" EL evaluation changes the component is always keeping the original state of disabled even after updates which is bad. I am trying to re-enable an item but once its set it never gets reset.

[melloware]

I have reverted the fix for now.

[Rapster]

Can you provide a sample please? I need to do something similar than this ticket

[melloware]

@Rapster You need a sample of how this fix broke the FluidGrid? Like a PrimeFaces Test case?

[Rapster]

Yes please

[melloware]

OK will post it here when complete so you can see it.

[melloware]

Attached:
pfe-571.zip

Run the demo and you will see item3 is disabled by default. When you press "Save" button it should re-enable item3 but it does not, it remembers its disabled state.

If you change the pom.xml to PFE 6.2.4 you will see its working fine.

[melloware]

Also I discovered Primefaces has a SavedState class that looks like it duplicates (or was moved from PFE) as our SavedEditableState.

[melloware]

switched to extend core PF SavedState

public class SavedEditableValueState extends SavedState {

[tandraschko]

If we fix this in the future, please also try a case that the disabled flag could reference the current var from the dynaForm.