GithubHelp home page GithubHelp logo

Banner illustration about design HOT 10 CLOSED

primer avatar primer commented on May 2, 2024 1
Banner illustration

from design.

Comments (10)

emilybrick avatar emilybrick commented on May 2, 2024 1

Hey @jhuashao excited you are going to start working on this! We'll catch up about this shortly, but just wanted point to some helpful Figma files:

design guidelines

og image template for social sharing

primer.style team page (rough, a bit out of date)

primer.style what's new page (rough, a bit out of date)

primer.style raw sketches

from design.

emilybrick avatar emilybrick commented on May 2, 2024 1

The general layout is feeling nice! I dig the movement in the illo. Couple thoughts:

  • I think the three boxes could use a bit more breathing room between them, even if it means making them a bit smaller.

  • Dot grid: I would opt for the dot grid instead of the diamond grid you have in the bottom right, so it's consistent with the other illustrations
    screenshot 2018-11-01 14 55 50
    screenshot 2018-11-01 14 56 17

  • Stroke width: I'm not sure how valid this is, but my gut feeling is that we should stick with the same stroke with across the board unless you're layering shapes (like those two squiggles maybe)). I would at least stick with thicker stroke width for that long path (the path that moves across the entire composition).

  • Paring it down a bit: I like the rectangle gradient, but I think you could get away with just one (instead of two). I wonder if we can incorporate more of the block-y bars in place of the gradient bar (once it's removed). One thing about the block-y bars I've noticed is that they usually appear stacked on top of one another, to signify "code lines" etc

  • Circles: The standalone circles feel out of place to me, without other shapes to compliment them. It might be cool to try pairing a circle with a smaller circle or different shape, similarly to:
    screenshot 2018-11-01 14 53 50
    screenshot 2018-11-01 14 53 42

  • On that note, I'm curious how the GitHub logo would work without the arcs/lines? As a standalone it looks nice, but in the overall composition I'm not sure if it fits as much – still really reminiscent of Atom to me.

  • I like the gridlines idea, however what's standing out to me right now is how sharp the contrast between the two boxes on the left are to the one on the right. I would suggest either using a darker blue fill color, or stick with an outline box for all three. It might (e.g. not sure if this is worth exploring) be interesting to layer the gridlines rectangle on top of the outline box. That said, I think that might only work if the fill-color is a darker blue, the light blue is a bit overpowering imo.

Thanks for continuing to work through this! I'm curious how @broccolini feels, since I'm new to this style as well.

from design.

emilybrick avatar emilybrick commented on May 2, 2024 1

One other super small note, I think it might be cool to think about the "box" as a solid layer. Meaning, some shapes can behind the layer, similarly to:
screenshot 2018-11-01 15 04 54

while other shapes can live on top of the layer:
screenshot 2018-11-01 15 05 27

I wonder if we can achieve the same type of effect in this first box, rather than shapes overlapping behind the box:
screenshot 2018-11-01 15 05 55

from design.

jhuashao avatar jhuashao commented on May 2, 2024 1

Finalization and Bodymovin Integration

After finalizing the illustration itself, I had a bit of poking around an After Effect library called Bodymovin, and decided to try a bit of animation to make it a little more lively.

Bodymovin, is a library that takes Aftereffects animations and converts them into JSON, which is then rendered as an SVG animation. Rather than use CSS and JS to wrangle animations in the web, this extension packages all that away into a tidy file. Airbnb loved the library, and extended its capabilities into iOS, Android, and React Native by creating Lottie

I went through some iterations of animating the file, but @emilybrick and @broccolini and I settled on the following:
banneranimation

For React, Bodymovin requires a wrapper, which I downloaded using this command:
npm install --save react-bodymovin
Full documentation here: https://www.npmjs.com/package/react-bodymovin

To test the animation out, I created a branch on primer.style and threw it into the homepage to see if it would work:
banner illustration final workflow recording

Renders well! And it’s fully responsive!🎉

I was really happy with the results and hope this workflow is something that others might find helpful too!

from design.

jhuashao avatar jhuashao commented on May 2, 2024 1

@emilybrick gonna check in w/ @shawnbot about implementation! I'll follow up with something more concrete soon

from design.

jhuashao avatar jhuashao commented on May 2, 2024

Design Guidelines: Banner Illustration Process

Research (w/ @emilybrick)
Design Guidelines Inspiration
screen shot 2018-10-31 at 3 12 05 pm

Keywords + Drafting:
Components are flexible, and allow for designer and developer velocity
Fluidity is key, and this is an important aspect of design guidelines
Foundations are critical, and provide guardrails for designers and developers

img_3972

Banner Iterations
Choice 1 — simplified, three elements, incorporating consistent elements, lends itself well to animation
10 31 2018 banner iterations-04

Choice 2 — more emphasis in foundations, rectangular vocabulary, slight shift in illustration style
10 31 2018 banner iterations-05

Choice 3 — more complex exploration with more elements, experimental pseudo data-visualization
10 31 2018 banner iterations-06

Moving Forwards
—investing more time and effort into Choice 1
—Notes from Critique:

  • square edges on boxes
  • introducing "planets: + space theme would need consistency with Atom

—Primary Next Steps

  • Refine drawing and finalize static version
  • Work with @shawnbot to implement on website, make sure sizing + layout works!

—Secondary Next Steps

  • Animating the illustration itself (Aftereffects)
  • Bodymovin' Integration!

from design.

jhuashao avatar jhuashao commented on May 2, 2024

Current iteration of Banner Design Illustration:

  • Added Atom illustration elements
  • Move towards space theme
  • Altered foundation elements to stroke borders
  • Redesigned "Layout" component
  • Converted dot motif to stars

banner 1 iterations-03

banner final 1

from design.

jhuashao avatar jhuashao commented on May 2, 2024

After @broccolini and @emilybrick's feedback, I opted for a simplified palette, as well as removing unnecessary clutter.

-Moved illustration to Figma
-Solid Layers for foundation squares
-Codelines following proper spacing
-Removed inconsistent wiggle lines
-Removed Atom lines
-Color corrected/ simplified palette on foundation boxes
-Reverted stars back to dots

I believe we're getting close to the final version!

frame 2 4

from design.

emilybrick avatar emilybrick commented on May 2, 2024

nice @jhuashao ! Do you want to post the primer.style pr in here?

from design.

jhuashao avatar jhuashao commented on May 2, 2024

@shawnbot did some fancy footwork and yasss it finally works!!!

https://primer-design-banner.now.sh/design

from design.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.