Comments (5)
A new release went out this morning which has included the pin-slash
icon. It can be seen here and is now included in the library and npm package. Thanks for the request, @yp05327.
Closing this out 🚀
from octicons.
I've started thinking about adding this request to the library, and realized that we'll have to flip the direction of our pin
icon, so that the slash follows the same directional conventions (slashing from top left to bottom right) of the rest of the library. This also actually seems like the right move for the pin
icon because more of the icons in the library that have a diagonal composition tilt the way the the flipped version of the pin
icon would (with the tip of the pin pointing left instead of right).
Here's my proposed solution for both an updated pin
and the new unpin
, at 2x and 1x in both 16px and 24px sizes:
@tallys, can you check with product owners to make sure swapping the direction of the pin
icon wouldn't be problematic?
from octicons.
Will follow up! Thanks @CameronFoxly
Ship it 🚀
from octicons.
Thanks for the request @yp05327 — I'll pass this along to the internal team!
from octicons.
Current pin icon is
My idea would a same icon, but with a strike-through, similar to these:
from octicons.
Related Issues (20)
- [Bug]
- [Bug] @primer/octicons-react `esm` is incorrectly exported
- Filled folder icon was removed in recent release HOT 2
- was the folder symlink icon removed for a reason? HOT 6
- [Bug] `@primer/octicons-react` v19.0.0 not published HOT 2
- [Feedback] No empty/unchecked checkbox to go with "checkbox" icon? HOT 2
- [Feedback] Repo Icons are inconsistent HOT 2
- [Feedback] HOT 1
- [Bug] Discrepancies Between Figma Octicons Set and React Library HOT 3
- Biling code
- Titel
- [Bug] HOT 1
- [Bug]: Using styled-octicons in development mode significantly bloats bundle HOT 2
- [Bug] Missing icons accessibility and accessibility-inset in 24px HOT 1
- [Feedback] Duplicated icons HOT 2
- [Feedback] Publish icon list as part of the build process HOT 1
- [Suggestion] Add `git-branch-deleted` and `tag-deleted` icons HOT 3
- [Bug] The SVGs in /build/svg/ don't have the `octicon` classes attached HOT 1
- [Bug] `@primer/octicons-react` includes raw SVG files, but are inaccessible HOT 1
- [Bug] `@primer/octicons` includes all the raw SVGs twice HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from octicons.