Comments (3)
Primer Components currently say
The Flex component behaves the same as the Box component except that it has display: flex set by default.
Previously, a Flex.Item component was used for flex item specific properties; Box now contains all those properties and should be used in its place.
so, at minimum we could deprecate FlexItem
to be consistent.
Assuming we're agreed on that, we are left to discuss if we want to keep FlexComponent
.
cc/ @joelhawksley @manuelpuyol thoughts?
from view_components.
@srt32 I think it might be worth looking at how we use these components internally and consider refactoring them to use Box. If that goes well, deprecation sounds like the right route.
from view_components.
I believe that flex
properties could be part of Classify (system_arguments)
from view_components.
Related Issues (20)
- `w` system argument hard to discover when looking for 'width' HOT 2
- `Primer::Classify::Utilities` does not support `font_size` or `border_radius` HOT 2
- Dismiss action of `Alpha::Banner` is not changable
- Option on `Primer::Alpha::Select` does not allow including a test selector
- Allow `Banner` to be rendered as a `<section>`
- `::Dialog` is always `aria-disabled=false` HOT 1
- Positioning and background of Dialog is wrong when opened without a trigger button HOT 1
- Bug: Dismissable Banner close button has autofocus
- Formally deprecate `Flash` and point people to Banner HOT 1
- Update ts compilation target to `es2020`
- [Banner] Render Banner as a region landmark labelled by a heading by default
- [Banner] Manage focus when PVC Banner is dismissed
- Primer::Alpha::ToggleSwitch jumps in the small variant
- Button with `scheme: :invisible` has different font colors HOT 1
- First row below the header in `Primer::Beta::Box` has rounded corners
- Primer::Beta::Button Add option to render a delete button HOT 1
- Link ViewComponent with tooltip renders tooltip label far from link HOT 1
- Changing params for component preview gives `no implicit conversion of String into Integer` error HOT 1
- Issue Title
- Breadcrumb links can't control the target attribute
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from view_components.