GithubHelp home page GithubHelp logo

Update primer/css version about view_components HOT 9 CLOSED

srt32 avatar srt32 commented on August 15, 2024
Update primer/css version

from view_components.

Comments (9)

colebemis avatar colebemis commented on August 15, 2024 3

@joelhawksley I'm sure it's possible, but it might be tricky to scope the styles so they don't conflict with Doctocat styles.

I think the easiest solution would be to use https://unpkg.com/@primer/css-next@canary/dist/primer.css, which should give us the same version that dotcom uses.

When primer/css#1131 is merged, we can go back to using https://unpkg.com/@primer/css/dist/primer.css.

from view_components.

srt32 avatar srt32 commented on August 15, 2024

@joelhawksley I think we are running on matching versions. Am I missing something?

from view_components.

joelhawksley avatar joelhawksley commented on August 15, 2024

@joelhawksley I think we are running on matching versions. Am I missing something?

I see that dotcom is using `"@primer/css-next": "0.0.0-6a1daf3"., which is the release candidate for v16.

from view_components.

srt32 avatar srt32 commented on August 15, 2024

Interesting! How should / could we keep things up to date? I can update the unpkg link manually now but this is going to break again...

from view_components.

srt32 avatar srt32 commented on August 15, 2024

Looking again, https://github.com/primer/css-next is a private mirror. I'm not sure that's going to work for this project...

from view_components.

manuelpuyol avatar manuelpuyol commented on August 15, 2024

Maybe @simurai could help us here?

We want to use the same PrimerCSS version as dotcom, but it looks like that version is not publicly available for us to use, since we get the CSS from unpkg now

from view_components.

joelhawksley avatar joelhawksley commented on August 15, 2024

@colebemis would it be possible to package and serve Primer CSS in the PVC doctocat site?

from view_components.

srt32 avatar srt32 commented on August 15, 2024

Aha, I was not expecting the unpkg link for css-next to exist given the repo is private ;). I made that switch in #278

from view_components.

srt32 avatar srt32 commented on August 15, 2024

Done via #278

from view_components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.