Comments (9)
@joelhawksley I'm sure it's possible, but it might be tricky to scope the styles so they don't conflict with Doctocat styles.
I think the easiest solution would be to use https://unpkg.com/@primer/css-next@canary/dist/primer.css
, which should give us the same version that dotcom uses.
When primer/css#1131 is merged, we can go back to using https://unpkg.com/@primer/css/dist/primer.css
.
from view_components.
@joelhawksley I think we are running on matching versions. Am I missing something?
from view_components.
@joelhawksley I think we are running on matching versions. Am I missing something?
I see that dotcom is using `"@primer/css-next": "0.0.0-6a1daf3"., which is the release candidate for v16.
from view_components.
Interesting! How should / could we keep things up to date? I can update the unpkg link manually now but this is going to break again...
from view_components.
Looking again, https://github.com/primer/css-next is a private mirror. I'm not sure that's going to work for this project...
from view_components.
Maybe @simurai could help us here?
We want to use the same PrimerCSS version as dotcom, but it looks like that version is not publicly available for us to use, since we get the CSS from unpkg
now
from view_components.
@colebemis would it be possible to package and serve Primer CSS in the PVC doctocat site?
from view_components.
Aha, I was not expecting the unpkg link for css-next to exist given the repo is private ;). I made that switch in #278
from view_components.
Done via #278
from view_components.
Related Issues (20)
- [Banner] Manage focus when PVC Banner is dismissed
- Primer::Alpha::ToggleSwitch jumps in the small variant
- Button with `scheme: :invisible` has different font colors HOT 1
- First row below the header in `Primer::Beta::Box` has rounded corners
- Primer::Beta::Button Add option to render a delete button HOT 1
- Link ViewComponent with tooltip renders tooltip label far from link HOT 1
- Changing params for component preview gives `no implicit conversion of String into Integer` error HOT 1
- Issue Title
- Breadcrumb links can't control the target attribute
- Automatic width calculation of `ActionMenu` inside `Dialog` is broken HOT 1
- `ToggleSwitchForm` does not work with Turbo Responses HOT 2
- Anchored position element align= attribute conflicting with html align attribute HOT 1
- Caption of ToggleSwitchForm is given too little space HOT 1
- Group headers are not correctly aligned when using `anchor_align: :end` in `Primer::Alpha::ActionMenu`
- SassC::SyntaxError during Rails asset precompilation HOT 2
- Invisible scheme for danger buttons is missing HOT 3
- Add ability to set a `test_selector` on `Primer::Alpha::Item#description` HOT 2
- `Primer::Beta::Link` is missing support for trainling and leading visuals HOT 1
- Clarify `.tooltipped` migration linter message
- Align-end Action menu with long item label or description is misaligned HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from view_components.