Comments (4)
This goes even further. The LayoutDependencyType needs to be updated when an element leaves or enters the DOM. Maybe we just update EVERYTHING when an element disconnects or connects? Or is that overkill? Maybe it only affects the layout behavior anyway. Or maybe not. There might be behaviors (e.g. signal) that search for events using a selector. It needs to be updated as well.
from scrollmeister.
What we basically need to do is to call _updateProperty
for dependencies
with the same rawValue (e.g. inherit
). This will get the correct elements from the DOM and the guide-layout will automatically do its thing due to layout:update event.
from scrollmeister.
Now the thing is that this should be a general purpose solution. Right now we have layoutdependency
and template
that depend on the DOM. There will be at least a third one cssselector
. These should all be updated when a new element (MeisterComponent) connects or disconnects from the DOM. This is not related to the layout behavior at all, it's just the first place that we ran into it.
from scrollmeister.
Now we're talking: if you create a new disconnected element-meister the behaviors will crash, since they expect the element to be connected. Luckily, there is a isConnected
property and we can postpone behavior scheduling.
from scrollmeister.
Related Issues (20)
- MutationObserver HOT 1
- <content-meister> HOT 2
- <element-meister> -> <section-meister>
- scrollbar behavior
- Experiment with native scrolling on touch HOT 4
- youtube behavior pause outside of viewport
- Web workers HOT 1
- Expose scroll velocity to gl-effect schaders HOT 1
- viewport-events behavior
- Can someone please tell me why fake scrolling is so much smoother on IOS?
- Timing issue with appending new items HOT 10
- RatioType needs to accept floats as well
- clip: true for non-followers
- `default` and conditions
- https://docusaurus.io/
- Allow spacing around scroll-meister
- height: inherit for followers
- media behavior
- scroll-into-view behavior
- DOM manip perf
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scrollmeister.