GithubHelp home page GithubHelp logo

Comments (2)

Prinzhorn avatar Prinzhorn commented on September 13, 2024

Problem: this will trigger attributeChangedCallback and parse the whole thing again. For some prop types such as LayoutDependencyType this might have performance implications. Instead we could just update the internal representation like a-frame does. In debug mode we can then force-sync the attribute, which will cause a full re-parse. a-frame uses a flushToDOM method.

For now we're not syncing the values back to the attribute, just interally.

The tricky part is not everything can trivially be serialized back, e.g. LayoutDependencyType. We might have to store the original value (e.g. selector or 'skip 2') attached to the array.

LayoutDependencyType now also returns the original value so we can easily stringify (which the schemaParser can do now and is also tested)

from scrollmeister.

Prinzhorn avatar Prinzhorn commented on September 13, 2024

64e90cc

from scrollmeister.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.