Should animate parameter on NavigationService.Navigate method signature be removed? about prism

[Mike-E-angelo]

I would vote for that. 👍 Animation should be a concern of the view, ideally. With that said, my Xamarin.Forms navigation experience is very minimal (but, that parameter has always bugged me). It would be great to hear from someone with a good deal of experience around this parameter to get their take on why it's being passed around like it is and not being handled by the view.

[powerdude]

I would suggest leaving it has i've seen quite a number of people on forums want something like this. It becomes necessary when you want to push/pop a number of forms on/off the stack but not make it obvious you are doing so. I haven't run into the scenario myself, but I see it is possible.

[omares]

@brianlagunas could you please link the current implementation?

In general, please keep the option to control the animation, controlling it is an important part of handling the navigation stack "behind the scene".

[brianlagunas]

@omares here is the interface definition:
https://github.com/PrismLibrary/Prism/blob/master/Source/Xamarin/Prism.Forms/Navigation/INavigationService.cs

I am thinking that the animated parameter should at least go last since it is probably not used as the useModalNavigation would be.

[brianlagunas]

What about passing the "animated" option as a NavigationParameter, instead of placing it on the Navigate method signature?

[Mike-E-angelo]

That is definitely better. I myself would prefer a clever use of an attached property somewhere, in the most ideal of situations. Again, that's just my input without me sticking my nose into it too much yet.

[brianlagunas]

For now, I just moved the animated parameter to the end of the method signature. I will re-evaluate if the community is completely against it.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.