GithubHelp home page GithubHelp logo

Comments (3)

CPerezz avatar CPerezz commented on August 14, 2024 1

Seems fine to me! We discussed this with @han0110 and @ChihChengLiang and agreed to setup the toolchain file targeting stable and not overriting it in the CI!

from zkevm-circuits.

han0110 avatar han0110 commented on August 14, 2024

I think right now we don't use features requiring nightly? For the stable version we are using 1.53 (stick to CI). Does the warning can't set wrap_comments = true from cargo fmt leads you think we are using nightly?

from zkevm-circuits.

Lawliet-Chan avatar Lawliet-Chan commented on August 14, 2024

Actually, I met a bug when I first built the code because of my old nightly version and I update rustc to fix it.

Maybe our codes don't need nightly, but we cannot guarantee the dependent libs don't have it. Sometimes some library requires a specific version of nightly.
So a unified version is more conducive to the standardization of the project. rust-toolchain can constrain and unify the version of nightly. It is friendly to developers.

from zkevm-circuits.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.