GithubHelp home page GithubHelp logo

Merge TypeValue and AttributeValue about creco HOT 3 CLOSED

prmr avatar prmr commented on September 27, 2024
Merge TypeValue and AttributeValue

from creco.

Comments (3)

asutcl avatar asutcl commented on September 27, 2024

I have started the merge in the attribute_merge branch. A few things I want to post if anyone has objections please let me know.

I've created a few getters to get either a double, a string or a boolean. This should be done after checking the type against the Type enum.

Should we keep both INTEGER and DOUBLE in the enum or collapse them into a NUMERIC category with the possibility of having a STAR category for 5 star ratings?

I have marked the getValue() that returns an object as deprecated for now to give everyone the time to adjust their code.

from creco.

asutcl avatar asutcl commented on September 27, 2024

I have merged the main branch into the attribute_merge branch. There were a few conflicts with the SearchController. I didn't merge back into master. I have fixed them but if you were working on it please merge the attribute_merge into your code and fix conflicts if there are any and check that it still works as intended.

This issue will remain open because I have not merged back into the main due to this fact.

The ranges should also probably be moved to the ScoredAttribute class. This will require a bit of code reworking in the SearchController so I will wait to discuss this before doing so.

from creco.

asutcl avatar asutcl commented on September 27, 2024

AttributeValue is now deprecated, use TypedValue instead.

from creco.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.