incorrect check for arg undefined about p5.js

[evhan55]

@lmccart

I looked through the file for 'undefined' and found places where you are already doing the check that way. Are there other instances I should be looking for?

[lmccart]

@evhan55 there are a few places I'm doing it correctly (using typeof) but there are a lot of overloaded fxns where I'm distinguishing between types by checking if the last args exist. for example:

https://github.com/lmccart/processing-js/blob/master/lib/pjs.js#L1016

should remove check if (x) and replace with if (typeof x === 'undefined'), etc.

[evhan55]

@lmccart cool, I see now, ok I will look for them

Bocoup training also suggests treating method overloads with this check:

if(arguments.length === 0) { then do this thing }
etc.
but I will keep typeof !== 'undefined' for now

[lmccart]

@evhan55 oh that's a good point... go with that instead if you think it's better!

[evhan55]

@lmccart I'll stick with typeof for now and we can see later!

[evhan55]

closing for now and opening a new one about typeof vs. arguments