GithubHelp home page GithubHelp logo

Comments (4)

davepagurek avatar davepagurek commented on June 14, 2024 1

oh I bet it's because the next line is region._pixelDensity = pd; instead of region.pixelDensity(pd); -- the latter should divide the width and height back again:

p5.js/src/image/p5.Image.js

Lines 253 to 255 in 17304ce

// Adjust canvas dimensions based on pixel density
this.width /= density;
this.height /= density;

from p5.js.

Gaurav-1306 avatar Gaurav-1306 commented on June 14, 2024 1

I understand the mistake there. Let me make a new commit. Will change according to Dave's suggestion.

from p5.js.

ffd8 avatar ffd8 commented on June 14, 2024

@davepagurek @Gaurav-1306 – curious if you also experience the issue mentioned above. I tracked down the commit that changed the get() along with similar changes for pixelDensity(), which came out of this issue.

from p5.js.

davepagurek avatar davepagurek commented on June 14, 2024

Hey @Gaurav-1306, I've got a PR opened here already: #6542 Could you give this one a review and see if it makes sense to you too?

from p5.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.