Comments (5)
As a workaround I believe we can loosen up the dependency to do ^2.1.0 | ^3.0.0
. See this diff.
We only have one use case with react-element-to-jsx library so far.
from chai-enzyme.
@ljharb how do you see the most ideal solution?
from chai-enzyme.
That won't solve it, since npm will still try to install the latest.
The ideal solution is that nothing is a singleton and nothing needs peer deps :-) but React is a singleton, so all react things must only specify React things as peer deps. In other words, if I want to use chai-enzyme (with react-element-to-jsx-string as a dependency), i must install react-addons-test-utils
as a top-level dep.
Another alternative is to simply remove that feature, and drop the dependency.
from chai-enzyme.
I think it's best to pin chai-enzyme to 0.4.2
, which is the latest release that doesn't pull in react-element-to-jsx-string
.
As an aside react-element-to-jsx-string
supports react 0.14.8
and above while we support 0.14
and above, maybe we should bump this too? thoughts? cc @vesln
from chai-enzyme.
bumping to the latest 0.14 seems just fine
from chai-enzyme.
Related Issues (20)
- [1.0.0-beta.0] Cannot assert descendant not present HOT 2
- Use of reserved word 'let' in strict mode HOT 3
- [1.0.0-beta.0] className assertion failing when element has multiple classNames HOT 10
- CLOSED: Dependency issues with new version of enzyme HOT 4
- React 15.0.0 and Enzyme 3.2.0 issue HOT 3
- Cannot find module 'enzyme/build/react-compat' HOT 4
- Cannot convert a Symbol value to a string
- to.have.text(undefined) does not break the tests
- Error message for shallow render contains HOT 4
- Patch version bump for fix merged in from PR#215? HOT 2
- Is this library still maintained? `[import Adapter from 'enzyme-adapter-react-15';]` HOT 5
- .should.have.html(...) broken in 1.0.0-beta.1
- .to.have.style() requires kebab-cased keys
- TypeError: to.have.style is not a function HOT 1
- setup is vague
- Flow types HOT 1
- Preact support? HOT 3
- Chai's `assert.` style supported ? HOT 2
- Cannot read property 'have' of undefined
- Support for React 17
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chai-enzyme.