GithubHelp home page GithubHelp logo

Comments (6)

julienmru avatar julienmru commented on June 2, 2024

I fixed quickly the issue by changing on line 1513:

          // Safari Windows adds first file several times so skip them.
          if (!names[file.name]) {

to

          // Safari Windows adds first file several times so skip them.
          if (true || !names[file.name]) {

You might want to improve the check a little more :)

from filedrop.

ProgerXP avatar ProgerXP commented on June 2, 2024

if (true || !names[file.name]) {

Wait, does iOS upload multiple files under the same name (file.name = local file name)? Can you give me list of file names that Safari passes to this piece of code (e.g. insert alert(file.name) before this check)?

Assuming it does, how do you differentiate between the uploaded files (client side or server side)?

from filedrop.

julienmru avatar julienmru commented on June 2, 2024

@ProgerXP: all files are passed as "image.jpg" on iOS.

from filedrop.

ProgerXP avatar ProgerXP commented on June 2, 2024

@ProgerXP: all files are passed as "image.jpg" on iOS.

Duh. Okay, fixed it with:

if (!names[file.name] || file.name == 'image.jpg') {

Please test if it works.

Also, on which iOS version you've tested FileDrop? 6, 7, 8? I'm going to add this info to support list if it works there as well.

from filedrop.

julienmru avatar julienmru commented on June 2, 2024

It works on iOS 7 and 8.

from filedrop.

ProgerXP avatar ProgerXP commented on June 2, 2024

Great. If my fix works - please close this issue.

from filedrop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.