Comments (6)
Oh, fascinating. Definitely open to it. For reference/docs here is more info I found: https://developer.ibm.com/technologies/systems/articles/pa-dalign/
So this would be for all messages I'm assuming?
from qmux.
Yes, this would be for all messages. If am I to fix the message alignment, I might as well define a common header structure to make it much easier to know the expected message size. I will make significant changes to the document structure, and then you can take a look and see if you want to adopt the changes. It would be great if we end up both using a common protocol, otherwise it's no big deal, I'll just use a different name. I also want to ensure that the protocol can evolve with some backward compatibility.
from qmux.
@progrium okay, I've begun my work and I am clearly going to redesign the whole thing my way at this point, so you may not want to the final result when I'm done. We still have a common goal, so there are bits and pieces we can share. I've reviewed QMUX and the original SSH protocol, and there's one thing that eludes me so far: how would you support SOCKS5 on top of QMUX?
OpenSSH has this nice SOCKS5 tunneling feature that is an improvement over the regular TCP tunnel, and I intend to support SOCKS5 as well. However, I couldn't find the part of QMUX or the original SSH protocol that lets you specify the destination of the channel to open (IP address or hostname + port). Unlike a tunnel with a fixed destination, SOCKS5 requires that you specify where to connect. Is this something you wanted for QMUX as well?
from qmux.
Here's my draft revised protocol draft, let me know if you're interested, otherwise you can just close this issue and I'll move on with my own variant: https://github.com/awakecoding/qmux/blob/protocol-update/SPEC.md
from qmux.
I like some of the improvements but you're right we might be diverging pretty quickly. Is there a benchmark or test that could be done to show the performance difference of memory-aligning vs not (assuming a target platform/architecture)?
from qmux.
I don't have benchmarks, but to be honest, the performance will likely be very similar. It is just a good idea to pre-pad the data structures so the compilers won't, making it much easier to just transfer data structures as-is with minimal transformation between the wire format and the memory format (aside from little endian vs big endian).
I don't want to steer you in a different direction, I have already modified the protocol beyond recognition with the following:
- structure memory alignment
- common header structure
- maximum fragment size (65535)
- type-length-value (TLV) encoding
- move variable-length field to body
- assign 'variable' names to each field
- channel destination URL encoding
- reintroduce reason code and string
This new draft is what I'll use for my V1 of "JMUX" in jetsocat. It'll mostly be interesting to follow what happens on my side, but it's no longer relevant for QMUX unless you wish to significantly change it and take the same direction I'm taking.
I'll close this issue, thanks for your help
from qmux.
Related Issues (9)
- typescript: split transport into deno and browser modules HOT 2
- typescript: move deno conn wrapper in tests into transport/deno/tcp.ts
- typescript: add deno websocket transport
- A few queries regarding using this tool HOT 1
- encount error when i try to run my own server instance HOT 2
- example with two sessions HOT 3
- Are there any security issues with the demo? HOT 1
- Constant vhost errors from server HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from qmux.