GithubHelp home page GithubHelp logo

Comments (3)

TaeyeonRoyce avatar TaeyeonRoyce commented on September 25, 2024 1

Hi @knjk04, I solved this issue (move model package inside book package) and I'd like to say about how I solved this.
First, move model package inside book package. As you noticed, it causes "com.karankumar.bookproject.model.PredefinedShelfName.READ".
So I fixed JPA query where in method "findReadShelf2" which approaches to PredefinedShelfName.

After work, I run all test and passed except for the test that failed in the main branch. (ReadingGoalControllerIntegrationTest)

As you know, all classes that imported model package have been changed.
I also bring back some setting files such as "application-dev.properties" and "docker-compose.yml".

Please check my PR and let me know if I missed or did wrong.
Thank you for assigned me.

from book-project.

TaeyeonRoyce avatar TaeyeonRoyce commented on September 25, 2024

Hi, I'm a student who studies programming(Java, Spring).
I'm recently finding open source to contribute and I want to do about this issue.
I might be insufficient to solve this issue, but I want to fork this project and analyze codes to try it.
I already read contribution docs. Please let me try this issue.

from book-project.

knjk04 avatar knjk04 commented on September 25, 2024

Hi @TaeyeonRoyce, thanks for offering to help out with this. I'll assign you to it. If you need a hand, please don't hesitate to reach out by creating a GitHub Q&A discussion or on our Slack workspace

from book-project.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.