Missing indexes and data types on tables about encrypted-core-data

[sigmundfridge]

The background to this can be seen here

#67

As an overview, I looked at some stats using sqlite3_status and found PAGECACHE_OVERFLOW slowly increasing till the cache_size cap was reached. At this point my database performance became unusable for intensive queries (mainly BLOB retrieval).

[sigmundfridge]

So I think the indexing issue was fixed here 972ee91 (my mistake in not updating my code before raising this issue).
I've also realised that SQLite doesn't require data types (everything is saved as a string).

[gavin-black]

You are correct, indexes have been added, just went and verified that it was actually occurring. Thank you for tracking down that the fix was already in place.

Also ECD does save all data as strings. While not optimal, we haven't ran into any large issues because of it. Are you having headaches because of the lack of types under the hood? The types should still be preserved at the Objective-C level.

Did the indexes help your original BLOB slowdown issue, or is it still occurring?

[sigmundfridge]

I thought that the data types might be an issue but I don't think it is. I looked into SQLite further and it looks like the dynamic data typing makes specifying them pointless.

The performance stats are identical to the previously reported (#67). However, the performance is greatly improved. There is a very slight drop off in performance as the database grows but nothing like before, where the app would completely freeze for 10+ seconds whilst retrieving the BLOB.