Comments (14)
Let's do this slightly differently: can you file a PR which re-does the website according to this design but doesn't include the "Examples" section? This way you'll only have one interactive editor to work with.
Once this is ready and lands, I can help you add those two extra examples.
from projectfluent.github.io.
I'm a bit concerned about the copy in the mockup. It promises a bunch of stuff we don't have yet.
Also, I'd avoid wordings like "unfair", that makes us confrontational instead of improving.
from projectfluent.github.io.
yep!
from projectfluent.github.io.
@mathjazz - any feedback/suggestions on the design?
from projectfluent.github.io.
Good job!
I have some tiny ideas for improvements, none of which should block the release.
I'd rather provide my input after we're live - to avoid blocking us further. Is that ok with you?
from projectfluent.github.io.
yeah! let's push it live and then improve :)
from projectfluent.github.io.
There are a few details which I'd like to improve going forward. I'm listing them here in case you choose to fix them before filing the PR:
- the text alignment in the list of benefits is weird and the icons don't make much sense,
- the font size of the examples output is too small,
- "Learn more" is aligned to the right and I don't think it looks good; perhaps remove it and link to the principles directly from the text?
- the
liked-comment
example is missing the$user
external, - I'd like to have a more prominent link to the playground,
- we don't have a Twitter account which the footer has an icon for,
- the chevron looks like something was supposed to expand/collapse.
from projectfluent.github.io.
I assume this is so because it's still a mockup. I'd r- if the PR has it too ;)
from projectfluent.github.io.
The "unfair" copy comes verbatim from https://github.com/projectfluent/fluent/wiki. @Pike feel free to edit it to better suit your liking. Thanks!
from projectfluent.github.io.
Thanks for the feedback! I'll apply as much of the feedback as I can, although at some places negative feedback is not easily fixable as it is a matter of preference.
In particular:
the text alignment in the list of benefits is weird and the icons don't make much sense,
What do you mean "text alignment is weird" and can you suggest better icons from this list http://fontawesome.io/icons/ ? It would be more helpful for me than trying to guess icons to your liking.
the font size of the examples output is too small,
It's pretty tricky to pick the font that fits and spaces everything, I'll try to increase it.
"Learn more" is aligned to the right and I don't think it looks good; perhaps remove it and link to the principles directly from the text?
I believe it's a matter of preference. I do like it :) Do you think your preference should triumph mine?
I'd like to have a more prominent link to the playground,
Where would you like to have it? One idea I can see here is to link playground from each example widget. Something like "Play with it" that links to this example in playground?
we don't have a Twitter account which the footer has an icon for,
Hashtag projectfluent on twitter? :)
the chevron looks like something was supposed to expand/collapse.
What's your recommended glyph to use?
from projectfluent.github.io.
What do you mean "text alignment is weird" and can you suggest better icons from this list http://fontawesome.io/icons/ ? It would be more helpful for me than trying to guess icons to your liking.
I'd suggest narrower text, no icons and no <br>
. Compare:
Versus:
It's pretty tricky to pick the font that fits and spaces everything, I'll try to increase it.
Yes, that's the general challenge :)
I believe it's a matter of preference. I do like it :) Do you think your preference should triumph mine?
When two personal preferences collide, we find ourselves in need of a solution which moves us past the stale mate.
Where would you like to have it? One idea I can see here is to link playground from each example widget. Something like "Play with it" that links to this example in playground?
Yeah, maybe something like this provided it does not increase the visual clutter. If each example had its title (see below) perhaps we could add an (Open in playground)
link next to it.
Hashtag projectfluent on twitter? :)
Or just remove the iconβ¦
What's your recommended glyph to use?
I recommend not using a glyph and instead using titles: Interactive example
above the editor and Result
or Output
above the output.
from projectfluent.github.io.
Applied your feedback.
I don't like the list icon removal, but I don't feel like spending too much time on it.
I applied most of your feedback except of:
- Didn't have time to add the "Open in playground" thing. I'd like to add it, but would prefer not to block this PR any further, and will work on it in a separate one.
- I didn't remove the chevron and didn't replace it with text because I feel like it becomes unnecessarily cluttered. I hope you're ok to let it be the way it is now.
from projectfluent.github.io.
For the Open in playground - maybe we could use similar UI to what Rust book does - https://doc.rust-lang.org/book/first-edition/trait-objects.html - use the play arrow to open a playground with the example?
from projectfluent.github.io.
@zbraniecki With #9 merged, can we close this issue?
from projectfluent.github.io.
Related Issues (12)
- Add Fluent for Developers Guide HOT 2
- Examples title doesn't fit in one line. HOT 2
- projectfluent.io does not exists HOT 1
- Enable and enforce HTTPS HOT 2
- Move to HTTPS HOT 1
- Fix the known vulnerability HOT 1
- Update ACE highlighting HOT 2
- Improve the Get Started docs
- Weird font formatting on firefox/linux HOT 1
- License
- Link to Rust implementation is broken HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from projectfluent.github.io.