GithubHelp home page GithubHelp logo

Comments (12)

brancz avatar brancz commented on July 17, 2024 3

@eyalzek they are different problems. The configmap generator was there to bin-pack dashboards into configmaps, which was later migrated from python+bash scripts to jsonnet. The problem here is that a single dashboard is larger than the configmap size limit, which no bin-packing can solve as the item is larger than the bin to begin with :)

from kube-prometheus.

afirth avatar afirth commented on July 17, 2024 3

@michaelpietzsch @metalmatze: Since @aslafy-z 's PR kiwigrid/k8s-sidecar#16 was merged, this works great in the sidecar and is already supported by the helm chart. I believe the sidecar only supports one file/CM though.

apiVersion: v1
kind: ConfigMap
metadata:
  name: nginx-ingress-dashboard
  namespace: prometheus-operator
  labels:
    grafana_dashboard: "1"
data:
  # fetch https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/grafana/dashboards/nginx.json with the grafana sidecar
  nginx-ingress.json.url: https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/grafana/dashboards/nginx.json

from kube-prometheus.

metalmatze avatar metalmatze commented on July 17, 2024

Do you combine all dashboards into one ConfigMap? We actually improve that in brancz/kubernetes-grafana by having one ConfigMap per dashboard.

from kube-prometheus.

michaelpietzsch avatar michaelpietzsch commented on July 17, 2024

from kube-prometheus.

metalmatze avatar metalmatze commented on July 17, 2024

Not sure how we can work around the size limits of ConfigMaps to be honest... 😕
Maybe you can try to improve the dashboard so it also reduces its size?

from kube-prometheus.

michaelpietzsch avatar michaelpietzsch commented on July 17, 2024

from kube-prometheus.

metalmatze avatar metalmatze commented on July 17, 2024

Yes, a sidecar like this was used in the past by kube-prometheus too:
https://github.com/coreos/prometheus-operator/tree/release-0.19/contrib/grafana-watcher

Otherwise you could extend the Grafana image with your dashboard.

Either way, I don't think there's a way of using the ConfigMaps approach if the dashboard is that big.

from kube-prometheus.

brancz avatar brancz commented on July 17, 2024

Do you know which dashboard is the one that's causing this? A dashboard larger than 1Mb sounds like it would be rather bloated in the first place, improving that sounds like a good idea either way. Otherwise you could maybe look into other volume mounts like a git volume.

from kube-prometheus.

eyalzek avatar eyalzek commented on July 17, 2024

I don't really understand, as per:
prometheus-operator/prometheus-operator#535
https://github.com/eedugon/grafana-dashboards-configmap-generator

there was some kind of a workaround integrated into the repo, which was merged:
https://github.com/coreos/prometheus-operator/pull/567/files

but it was removed from the repo for some reason? Is there no workaround for this problem using the latest version?

from kube-prometheus.

stale avatar stale commented on July 17, 2024

This issue has been automatically marked as stale because it has not had any activity in last 60d. Thank you for your contributions.

from kube-prometheus.

stale avatar stale commented on July 17, 2024

This issue has been automatically marked as stale because it has not had any activity in last 60d. Thank you for your contributions.

from kube-prometheus.

brancz avatar brancz commented on July 17, 2024

Closing due to inactivity.

from kube-prometheus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.