Comments (4)
@mxinden, could you take a look? I'd like to implement it If it sounds reasonable
from client_rust.
Thank you for the code snippets. Generally I am not opposed to moving to hashbrown
. That said, I am not yet fully sure I understand the rational.
Are you trying to optimize performance? If so, would you mind providing data on how much the above would safe you?
Are you trying to optimize ergonomics? If so, I don't think having to implement Equivalent
is any better than calling to_string()
.
from client_rust.
I have huge label sets (10+ items) and can't formalize them in static types, it's just Strings in general. I have &str slices during data processing and copying them to locate the counter doesn't look good.
I've added some bench in PR:
The best option is counter family with custom type label set
. It doesn't contain allocations and is very cheap for hashing.
counter family with custom type label set and direct lookup
search by type with 3 string fields&Labels {method: "GET".to_string(), url_path: "/metrics".to_string(), status_code: "200".to_string()}
- 61.247 ns
counter family with custom type label set and equivalent lookup
- the same but without copying - 13.324 ns
counter family with Vec<(String, String)> label set
time: [104.90 ns 106.36 ns 107.95 ns]
Found 7 outliers among 100 measurements (7.00%)
4 (4.00%) high mild
3 (3.00%) high severe
counter family with custom type label set
time: [6.4575 ns 6.4720 ns 6.4883 ns]
Found 13 outliers among 100 measurements (13.00%)
8 (8.00%) high mild
5 (5.00%) high severe
counter family with custom type label set and direct lookup
time: [61.076 ns 61.247 ns 61.422 ns]
Found 9 outliers among 100 measurements (9.00%)
8 (8.00%) high mild
1 (1.00%) high severe
counter family with custom type label set and equivalent lookup
time: [13.291 ns 13.324 ns 13.358 ns]
from client_rust.
Perhaps using `Cowˋ would be useful?
from client_rust.
Related Issues (20)
- Allow flattening of a struct through derive(EncodeLabelSet) at any position HOT 2
- Make `Descriptor::new` `const` HOT 1
- feat: derive register logic on struct of metrics HOT 2
- Allow multiple labels in sub_registry_with_label method HOT 2
- Allow root registry creation with prefix AND label(s) HOT 1
- Implement native histograms HOT 1
- Escaping? HOT 3
- Public encoding functions? HOT 4
- Encoder without EOF HOT 5
- Custom Collector with `sub_registry_with_prefix` outputs name multiple times HOT 3
- Allow iterating the metrics on an registry HOT 1
- Allow construct a histogram family with a closure HOT 2
- mips: EncodeCounterValue implementation missing for u32?
- Histogram with empty family labels creates unparseable metrics output HOT 1
- text::DescriptorEncoder writes incorrect metric names HOT 2
- UTF-8: Implement support in Rust client library
- Implement Atomic for usize HOT 3
- Counter `HELP` and `TYPE` lack `_total` suffix HOT 5
- Provide a way to prevent unbounded metric growth HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from client_rust.